Skip to content

Comments

cage: 0.1.5 -> 0.1.5-unstable-2024-07-29; wlroots_0_16: drop#331623

Merged
wineee merged 2 commits intoNixOS:masterfrom
emilazy:push-yxttoylpkomv
Aug 8, 2024
Merged

cage: 0.1.5 -> 0.1.5-unstable-2024-07-29; wlroots_0_16: drop#331623
wineee merged 2 commits intoNixOS:masterfrom
emilazy:push-yxttoylpkomv

Conversation

@emilazy
Copy link
Member

@emilazy emilazy commented Aug 1, 2024

Description of changes

Includes support for wlroots 0.17 and a fix for disabling XWayland.

Issue asking for a release: cage-kiosk/cage#337

Diff: cage-kiosk/cage@v0.1.5...d3fb99d

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

emilazy added 2 commits August 1, 2024 23:30
Includes support for wlroots 0.17 and a fix for disabling XWayland.

Issue asking for a release: cage-kiosk/cage#337

Diff: cage-kiosk/cage@v0.1.5...d3fb99d
No remaining users in the tree, and another FFmpeg 4 dependency
vanquished.
@ofborg ofborg bot added the 8.has: clean-up This PR removes packages or removes other cruft label Aug 2, 2024
@ofborg ofborg bot requested a review from primeos August 2, 2024 00:08
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Aug 2, 2024
@donovanglover
Copy link
Member

Result of nixpkgs-review pr 331623 run on x86_64-linux 1

2 packages built:
  • cage
  • wio

Copy link
Member

@donovanglover donovanglover left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and LGTM

@wineee wineee merged commit 4da3c4b into NixOS:master Aug 8, 2024
@emilazy emilazy mentioned this pull request Aug 21, 2024
13 tasks
@emilazy emilazy deleted the push-yxttoylpkomv branch August 26, 2024 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

8.has: clean-up This PR removes packages or removes other cruft 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants