Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libeatmydata: patch out LFS64 usage #324772

Merged
merged 1 commit into from
Jul 5, 2024
Merged

Conversation

alyssais
Copy link
Member

@alyssais alyssais commented Jul 5, 2024

Description of changes

This is a revised version of c7f51f0 ("libeatmydata: patch out LFS64 usage") (reverted in 7be23ec ("Revert "libeatmydata: patch out LFS64 usage"")) that doesn't break 32-bit Glibc builds.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

This is a revised version of c7f51f0 ("libeatmydata: patch out
LFS64 usage") (reverted in 7be23ec ("Revert "libeatmydata: patch
out LFS64 usage"")) that doesn't break 32-bit Glibc builds.
@alyssais alyssais mentioned this pull request Jul 5, 2024
47 tasks
Copy link
Contributor

@misuzu misuzu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works on i686-linux and armv7l-linux (glibc)

@yu-re-ka yu-re-ka merged commit daeb19c into NixOS:master Jul 5, 2024
27 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants