Release 24.05: update hercules ci packages#319390
Merged
roberth merged 5 commits intoNixOS:release-24.05from Jun 25, 2024
Merged
Release 24.05: update hercules ci packages#319390roberth merged 5 commits intoNixOS:release-24.05from
roberth merged 5 commits intoNixOS:release-24.05from
Conversation
Member
|
I think it is probably wise to rebase this onto |
Member
Author
|
They merge fine and I don't see anything that's worrying in the diffs. Also evaluates fine. This PR behaves a lot like updates in I appreciate your concern and thanks for the heads-up. |
Member
Author
|
Staging has released and I've found no issues after merging this locally. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Deliver stability improvements to 24.05.
Haskell package sets weren't normally updated on stable, so this is a bit new-ish. I've added a bit of code to replace packages. Previously (year ago?) I'd just used
non-hackage-packages.nixdirectly, but I figured the following is a nicer solution:Things done
hcihercules-ci-agentcachixhcihercules-ci-agentcachixnix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.