Skip to content

electron*: mark older versions as EOL #319252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vcunat merged 1 commit into from
Jun 12, 2024
Merged

electron*: mark older versions as EOL #319252

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkgs/development/tools/electron/binary/generic.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ let
++ optionals (versionAtLeast version "11.0.0") [ "aarch64-darwin" ]
++ optionals (versionOlder version "19.0.0") [ "i686-linux" ];
sourceProvenance = with sourceTypes; [ binaryNativeCode ];
knownVulnerabilities = optional (versionOlder version "27.0.0") "Electron version ${version} is EOL";
knownVulnerabilities = optional (versionOlder version "29.0.0") "Electron version ${version} is EOL";
};

fetcher = vers: tag: hash: fetchurl {
Expand Down
1 change: 1 addition & 0 deletions pkgs/development/tools/electron/common.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,6 +234,7 @@ in (chromium.override { upstream-info = info.chromium; }).mkDerivation (base: {
meta = with lib; {
description = "Cross platform desktop application shell";
homepage = "https://github.com/electron/electron";
knownVulnerabilities = optional (versionOlder info.version "29") "Electron version ${version} is EOL";
Copy link
Member

@emilylange emilylange Jun 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we usually remove the EOL electron-source versions and mark the binary electron_*-bin version EOL?
Not both?

See #295672 (c45702d and 1f9c426).

platforms = lib.platforms.linux;
license = licenses.mit;
maintainers = with maintainers; [ yayayayaka teutat3s ];
Expand Down