From 789263837921e9a6f65c5894068585f6c7896474 Mon Sep 17 00:00:00 2001 From: Alyssa Ross Date: Wed, 12 Jun 2024 09:07:36 +0200 Subject: [PATCH] electron*: mark older versions as EOL Link: https://www.electronjs.org/docs/latest/tutorial/electron-timelines#timeline Link: https://github.com/NixOS/nixpkgs/pull/318857#issuecomment-2161462390 --- pkgs/development/tools/electron/binary/generic.nix | 2 +- pkgs/development/tools/electron/common.nix | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/pkgs/development/tools/electron/binary/generic.nix b/pkgs/development/tools/electron/binary/generic.nix index f9e493e6b7cbd..a11baed163da2 100644 --- a/pkgs/development/tools/electron/binary/generic.nix +++ b/pkgs/development/tools/electron/binary/generic.nix @@ -42,7 +42,7 @@ let ++ optionals (versionAtLeast version "11.0.0") [ "aarch64-darwin" ] ++ optionals (versionOlder version "19.0.0") [ "i686-linux" ]; sourceProvenance = with sourceTypes; [ binaryNativeCode ]; - knownVulnerabilities = optional (versionOlder version "27.0.0") "Electron version ${version} is EOL"; + knownVulnerabilities = optional (versionOlder version "29.0.0") "Electron version ${version} is EOL"; }; fetcher = vers: tag: hash: fetchurl { diff --git a/pkgs/development/tools/electron/common.nix b/pkgs/development/tools/electron/common.nix index 3514d7cdad229..a615feabdad83 100644 --- a/pkgs/development/tools/electron/common.nix +++ b/pkgs/development/tools/electron/common.nix @@ -234,6 +234,7 @@ in (chromium.override { upstream-info = info.chromium; }).mkDerivation (base: { meta = with lib; { description = "Cross platform desktop application shell"; homepage = "https://github.com/electron/electron"; + knownVulnerabilities = optional (versionOlder info.version "29") "Electron version ${version} is EOL"; platforms = lib.platforms.linux; license = licenses.mit; maintainers = with maintainers; [ yayayayaka teutat3s ];