Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lightningcss: 1.24.1 → 1.25.0 #312669

Merged
merged 1 commit into from
May 19, 2024
Merged

Conversation

toastal
Copy link
Contributor

@toastal toastal commented May 18, 2024

<system-color> panic regression still persists
parcel-bundler/lightningcss#685

patch unmerged for napi & cargo auditable
parcel-bundler/lightningcss#713

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

1

Footnotes

  1. Please consider giving up MS GitHub or offering a non-proprietary, non-US-corporate-controlled mirror for this free software project. I wish to delete this Microsoft account in the future, but I need more projects like this to support alternative methods to send patches & contribute.

@toastal toastal requested a review from JohnRTitor May 18, 2024 14:04
<system-color> panic regression still persists
parcel-bundler/lightningcss#685

patch unmerged for napi & cargo auditable
parcel-bundler/lightningcss#713
@JohnRTitor
Copy link
Contributor

Result of nixpkgs-review pr 312669 run on x86_64-linux 1

1 package built:
  • lightningcss

@JohnRTitor JohnRTitor added 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package labels May 18, 2024
@fabianhjr fabianhjr merged commit 3ad3240 into NixOS:master May 19, 2024
32 of 35 checks passed
@toastal toastal deleted the lightningcss-1.25.0 branch May 20, 2024 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants