Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

directfb: use POSIX basename() #309583

Merged
merged 1 commit into from
May 7, 2024

Conversation

alyssais
Copy link
Member

@alyssais alyssais commented May 6, 2024

Description of changes

musl 1.2.5 no longer provides the GNU version. See #229439.

Upstream is dead so patching is probably our only option, but at least that means it's unlikely to break in a future release!

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

musl 1.2.5 no longer provides the GNU version.

Upstream is dead so patching is probably our only option, but at least
that means it's unlikely to break in a future release!
@alyssais alyssais added the 6.topic: musl Running or building packages with musl libc label May 6, 2024
@alyssais alyssais mentioned this pull request May 6, 2024
47 tasks
@ofborg ofborg bot requested a review from bjornfor May 6, 2024 15:53
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 501+ 10.rebuild-linux: 1001-2500 labels May 6, 2024
@alyssais alyssais changed the base branch from master to staging May 7, 2024 09:14
@ofborg ofborg bot requested a review from bjornfor May 7, 2024 09:41
@wegank wegank added 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package labels May 7, 2024
@SuperSandro2000 SuperSandro2000 merged commit 8da9f02 into NixOS:staging May 7, 2024
32 checks passed
@alyssais alyssais deleted the directfb-basename branch May 15, 2024 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: musl Running or building packages with musl libc 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 501+ 10.rebuild-linux: 1001-2500 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants