From df48037fb496f1a9daca324fb30d681b653be99b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Robert=20Sch=C3=BCtz?= Date: Sat, 26 Aug 2023 13:49:47 -0700 Subject: [PATCH 1/2] qutebrowser-qt5: replace qt5.qutebrowser Applications don't belong in the qt5 scope. (cherry picked from commit d248a1e7f7a3e839ec06cbb7776bcdb5fab67451) --- .../networking/browsers/qutebrowser/default.nix | 6 +++--- pkgs/development/libraries/qt-5/5.15/default.nix | 1 - pkgs/top-level/all-packages.nix | 4 ++++ 3 files changed, 7 insertions(+), 4 deletions(-) diff --git a/pkgs/applications/networking/browsers/qutebrowser/default.nix b/pkgs/applications/networking/browsers/qutebrowser/default.nix index 04de25c4988ae..c8b315893a52a 100644 --- a/pkgs/applications/networking/browsers/qutebrowser/default.nix +++ b/pkgs/applications/networking/browsers/qutebrowser/default.nix @@ -26,14 +26,14 @@ let stripRoot = false; }; - pname = "qutebrowser"; version = "3.0.2"; in python3.pkgs.buildPythonApplication { - inherit pname version; + pname = "qutebrowser" + lib.optionalString (!isQt6) "-qt5"; + inherit version; src = fetchurl { - url = "https://github.com/qutebrowser/qutebrowser/releases/download/v${version}/${pname}-${version}.tar.gz"; + url = "https://github.com/qutebrowser/qutebrowser/releases/download/v${version}/qutebrowser-${version}.tar.gz"; hash = "sha256-pRiT3koSNRmvuDcjuc7SstmPTKUoUnjIHpvdqR7VvFE="; }; diff --git a/pkgs/development/libraries/qt-5/5.15/default.nix b/pkgs/development/libraries/qt-5/5.15/default.nix index a2b38046c5a83..68a3e3531e19a 100644 --- a/pkgs/development/libraries/qt-5/5.15/default.nix +++ b/pkgs/development/libraries/qt-5/5.15/default.nix @@ -375,6 +375,5 @@ let if stdenv.buildPlatform == stdenv.hostPlatform then bootstrapScope.qttranslations else null; - qutebrowser = final.callPackage ../../../../applications/networking/browsers/qutebrowser { }; }); in finalScope diff --git a/pkgs/top-level/all-packages.nix b/pkgs/top-level/all-packages.nix index e13eb7086edf7..dc3ee1f3b2252 100644 --- a/pkgs/top-level/all-packages.nix +++ b/pkgs/top-level/all-packages.nix @@ -35031,6 +35031,10 @@ with pkgs; inherit (qt6Packages) qtbase qtwebengine wrapQtAppsHook qtwayland; }; + qutebrowser-qt5 = callPackage ../applications/networking/browsers/qutebrowser { + inherit (__splicedPackages.libsForQt5) qtbase qtwebengine wrapQtAppsHook qtwayland; + }; + qxw = callPackage ../applications/editors/qxw { }; rabbitvcs = callPackage ../applications/version-management/rabbitvcs { }; From 6d0eb53cd116bdc920d4d109fc5c2e8222efc3dc Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Robert=20Sch=C3=BCtz?= Date: Tue, 7 Nov 2023 20:41:03 -0800 Subject: [PATCH 2/2] qutebrowser: use spliced qt6Packages (cherry picked from commit 4bd758c9634eef2d58822b4aaa424051f613da0d) --- pkgs/top-level/all-packages.nix | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkgs/top-level/all-packages.nix b/pkgs/top-level/all-packages.nix index dc3ee1f3b2252..dead41100f6d7 100644 --- a/pkgs/top-level/all-packages.nix +++ b/pkgs/top-level/all-packages.nix @@ -35028,7 +35028,7 @@ with pkgs; }; qutebrowser = callPackage ../applications/networking/browsers/qutebrowser { - inherit (qt6Packages) qtbase qtwebengine wrapQtAppsHook qtwayland; + inherit (__splicedPackages.qt6Packages) qtbase qtwebengine wrapQtAppsHook qtwayland; }; qutebrowser-qt5 = callPackage ../applications/networking/browsers/qutebrowser {