Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

buildGraalvmNativeImage: Set maximum page size to 64K on aarch64-linux #269522

Merged

Conversation

diegobfernandez
Copy link
Contributor

Description of changes

This change enables packages built with buildGraalvmNativeImage to be used with all aarch64 kernel page sizes (4K, 16K and 64K) with the downside of a bit of wasted memory.

Continuation of #268774.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Priorities

Add a 👍 reaction to pull requests you find important.

@diegobfernandez
Copy link
Contributor Author

ofborg didn't add any reviewers so I will cc @thiagokokada here.

@thiagokokada
Copy link
Contributor

@ofborg build babashka clojure-lsp

@thiagokokada thiagokokada merged commit 9a525f8 into NixOS:master Nov 24, 2023
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants