-
-
Notifications
You must be signed in to change notification settings - Fork 18.1k
qt5: fix cross #264965
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
qt5: fix cross #264965
Changes from all commits
0e3b820
1048c90
4ef828d
760d596
e42b965
129b22f
80c437c
88568bb
e6f8c9d
08b8c3e
c8c7a45
dc61c90
2282888
de70669
930a631
274da99
753bf0e
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -313,7 +313,9 @@ let | |
|
|
||
| qmake = callPackage ({ qtbase }: makeSetupHook { | ||
| name = "qmake-hook"; | ||
| propagatedBuildInputs = [ qtbase.dev ]; | ||
| ${if stdenv.buildPlatform == stdenv.hostPlatform | ||
| then "propagatedBuildInputs" | ||
| else "depsTargetTargetPropagated"} = [ qtbase.dev ]; | ||
|
Comment on lines
-316
to
+318
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Seems wrong, the binaries in qtbase won't be in
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Remember,
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Are you sure it deals with only the library? https://github.com/nixos/nixpkgs/blob/753bf0e2933c4d66c0eb8481b60157419bae3629/pkgs/development/libraries/qt-5/hooks/qmake-hook.sh#L37
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I> Normally no, except it's QT, and QT has both qmake-which-runs-on-the-buildPlatform as well as libQtBase-which-is-built-for-the-hostPlatform mashed into the same package. Gotta add comments, really confusing |
||
| substitutions = { | ||
| inherit debug; | ||
| fix_qmake_libtool = ../hooks/fix-qmake-libtool.sh; | ||
|
|
@@ -338,6 +340,12 @@ let | |
| }); | ||
|
|
||
| finalScope = baseScope.overrideScope(final: prev: { | ||
| qttranslations = bootstrapScope.qttranslations; | ||
| # qttranslations causes eval-time infinite recursion when | ||
| # cross-compiling; disabled for now. | ||
| qttranslations = | ||
| if stdenv.buildPlatform == stdenv.hostPlatform | ||
| then bootstrapScope.qttranslations | ||
| else null; | ||
| qutebrowser = final.callPackage ../../../../applications/networking/browsers/qutebrowser { }; | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Applications don't belong here so I suggest #251671. |
||
| }); | ||
| in finalScope | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,12 @@ | ||
| { qtModule, qtbase, qtdeclarative }: | ||
| { lib | ||
| , stdenv | ||
| , qtModule | ||
| , qtbase | ||
| , qtdeclarative | ||
| }: | ||
|
|
||
| qtModule { | ||
| pname = "qtwebchannel"; | ||
| propagatedBuildInputs = [ qtbase qtdeclarative ]; | ||
| outputs = [ "out" "dev" "bin" ]; | ||
| outputs = [ "out" "dev" ] ++ lib.optionals (stdenv.hostPlatform == stdenv.buildPlatform) [ "bin" ]; | ||
| } |
Uh oh!
There was an error while loading. Please reload this page.