Skip to content

Comments

python311Packages.stem: enable on Python 3.11#262813

Merged
dotlambda merged 2 commits intoNixOS:masterfrom
dotlambda:stem-python311
Oct 23, 2023
Merged

python311Packages.stem: enable on Python 3.11#262813
dotlambda merged 2 commits intoNixOS:masterfrom
dotlambda:stem-python311

Conversation

@dotlambda
Copy link
Member

@dotlambda dotlambda commented Oct 22, 2023 •
edited
Loading

Description of changes

fixes #262807

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

cc @KiaraGrouwstra

@dotlambda dotlambda requested a review from rhendric October 22, 2023 21:56
@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Oct 22, 2023
mweinelt
mweinelt reviewed Oct 22, 2023
View reviewed changes
mweinelt
mweinelt reviewed Oct 22, 2023
View reviewed changes
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. and removed 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Oct 22, 2023
rhendric
rhendric approved these changes Oct 23, 2023
View reviewed changes
Copy link
Member

@rhendric rhendric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it builds, I have no objections (though I don't claim any specific knowledge of this package; my previous contribution was a drive-by ZHF fix).

@delroth delroth added the 12.approvals: 1 This PR was reviewed and approved by one person. label Oct 23, 2023
@dotlambda
python311Packages.stem: improve expression
96c294e 
Also add myself as maintainer.
@delroth delroth removed the 12.approvals: 1 This PR was reviewed and approved by one person. label Oct 23, 2023
@dotlambda
Copy link
Member Author

dotlambda commented Oct 23, 2023

Result of nixpkgs-review pr 262813 run on x86_64-linux 1

20 packages built:
  • electron-cash
  • electron-cash.dist
  • maigret
  • maigret.dist
  • nyx
  • nyx.dist
  • onioncircuits
  • onioncircuits.dist
  • prometheus-tor-exporter
  • python310Packages.stem
  • python310Packages.stem.dist
  • python310Packages.torrequest
  • python310Packages.torrequest.dist
  • python311Packages.stem
  • python311Packages.stem.dist
  • python311Packages.torrequest
  • python311Packages.torrequest.dist
  • qutebrowser
  • qutebrowser.dist
  • sherlock

@dotlambda dotlambda merged commit af80c5f into NixOS:master Oct 23, 2023
@dotlambda dotlambda deleted the stem-python311 branch November 4, 2023 11:28
@dotlambda dotlambda mentioned this pull request Nov 4, 2023
Closed
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mweinelt mweinelt mweinelt left review comments

@rhendric rhendric rhendric approved these changes

Assignees

No one assigned

Labels

6.topic: python Python is a high-level, general-purpose programming language. 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Build failure: qutebrowser

4 participants

@dotlambda @mweinelt @rhendric @delroth