hpp-fcl, python3Packages.hpp-fcl: init at 2.3.3 #232854
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nim65s
changed the title
ofborg
bot
added
8.has: package (new)
Laurent2916
approved these changes
May 23, 2023
wegank
approved these changes
May 29, 2023
wegank
reviewed
May 29, 2023
drupol
requested changes
May 29, 2023
| , python3Packages | ||
| }: | ||
|
|
||
| stdenv.mkDerivation rec { |
There was a problem hiding this comment.
I think we should use the finalAttrs pattern here.
Since this is your first PR, let me share a couple of useful links regarding this:
- History: https://discourse.nixos.org/t/avoid-rec-expresions-in-nixpkgs/8293
- Documentation: https://nixos.org/manual/nixpkgs/unstable/#mkderivation-recursive-attributes
- Recent example of implementation: https://github.com/NixOS/nixpkgs/compare/17f96f7b978e61576cfe16136eb418f74fab9952..9e6ea843e473d34d4f379b8b0d8ef0425a06defe
Cheers.
|
Please squash the last two commits, thanks! |
wegank
reviewed
May 29, 2023
nim65s
force-pushed
the
master
branch
2 times, most recently
from
07d7dac to
ee05702
Compare
|
(just added a |
wegank
reviewed
May 30, 2023
squashed: fix license by @wegank squashed: use finalAttrs, after review from @drupol Co-authored-by: Weijia Wang <[email protected]>
Janik-Haag
added
the
12. first-time contribution
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Hi,
This adds hpp-fcl
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)