Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustPlatform.buildRustPackage: make auditable the default #223320

Merged
merged 1 commit into from
Mar 27, 2023
Merged

rustPlatform.buildRustPackage: make auditable the default #223320

merged 1 commit into from
Mar 27, 2023

Conversation

figsoda
Copy link
Member

@figsoda figsoda commented Mar 27, 2023 •
edited
Loading

Description of changes

#200563

It has been a while since the initial implementation (#204686) was merged, and we haven't had any issues in the past 2 months.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@figsoda figsoda mentioned this pull request Mar 27, 2023
Closed
4 tasks
@figsoda figsoda added 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package labels Mar 27, 2023
RaitoBezarius
RaitoBezarius approved these changes Mar 27, 2023
View reviewed changes
Copy link
Member

@RaitoBezarius RaitoBezarius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super nice!

@figsoda figsoda merged commit 63b9aee into NixOS:staging Mar 27, 2023
@figsoda figsoda deleted the auditable branch March 27, 2023 23:32
@andresilva andresilva mentioned this pull request Apr 14, 2023
Closed
@amesgen amesgen mentioned this pull request Apr 14, 2023
Merged
12 tasks
@ghost ghost mentioned this pull request Apr 22, 2023
Merged
3 tasks
@ghost
Copy link

ghost commented Apr 22, 2023

This broke pkgsCross.*.cargo.

Fix: #227683

This was referenced Apr 29, 2023
Closed
Closed
@JohnRTitor JohnRTitor mentioned this pull request May 25, 2024
Open
@eljamm eljamm mentioned this pull request Jul 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zowoq zowoq zowoq approved these changes

@RaitoBezarius RaitoBezarius RaitoBezarius approved these changes

@winterqt winterqt Awaiting requested review from winterqt

@Mic92 Mic92 Awaiting requested review from Mic92

Assignees
No one assigned
Labels
6.topic: rust 10.rebuild-darwin: 501+ 10.rebuild-darwin: 5001+ 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+ 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@figsoda @RaitoBezarius @zowoq