Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vortex: init at 1.6.14 #203404

Closed
wants to merge 1 commit into from
Closed

vortex: init at 1.6.14 #203404

wants to merge 1 commit into from

Conversation

l0b0
Copy link
Contributor

@l0b0 l0b0 commented Nov 28, 2022

Description of changes

GPLv3 Mod manager by Nexus Mods.

Closes #147228. Depends on upstream issue.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

Closes NixOS#147228. Depends on [upstream
issue](Nexus-Mods/Vortex#2862).
@l0b0 l0b0 mentioned this pull request Nov 28, 2022
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Nov 28, 2022
@l0b0
Copy link
Contributor Author

l0b0 commented Nov 29, 2022

This doesn't build on my machine, but seems to build just fine on GitHub. Does anyone know enough about node-gyp/yarn to tell whether it's just an issue with my setup? If so I could just set this to ready for review.

@lilyinstarlight @jwong101 @malob

@natto1784
Copy link
Contributor

natto1784 commented Dec 2, 2022

The build is not triggered here because you did not add it to the all-packages.nix. As i said in the issue thread, it would not build even after that. Besides, there are issues with the code styling as well. Let's wait till all the "fixes" are merged in the source before adding multiple patches as well.

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 18, 2023
@l0b0
Copy link
Contributor Author

l0b0 commented Nov 27, 2023

Cancelling this since there's now NexusMods.App, which already supports Linux.

@l0b0 l0b0 closed this Nov 27, 2023
@l0b0 l0b0 deleted the feat/package-vortex branch November 27, 2023 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vortex mod manager
2 participants