Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sundials: reenable stackprotector on aarch64-darwin #188352

Merged
merged 1 commit into from
Sep 4, 2022

Conversation

tjni
Copy link
Contributor

@tjni tjni commented Aug 26, 2022

The original error that required disabling the stack protector on aarch64-darwin has been fixed in GCC (in #186477). Thus, reverting the patch made initially to resolve #127608.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

The original error that required disabling the stack protector on
aarch64-darwin has been fixed in GCC.
@tjni
Copy link
Contributor Author

tjni commented Aug 26, 2022

Result of nixpkgs-review pr 188352 run on aarch64-darwin 1

12 packages marked as broken and skipped:
  • librsb
  • octavePackages.fem-fenics
  • octavePackages.gsl
  • octavePackages.level-set
  • octavePackages.ocl
  • octavePackages.octproj
  • octavePackages.sparsersb
  • octavePackages.strings
  • octavePackages.tisean
  • octavePackages.vibes
  • octavePackages.video
  • octavePackages.vrml
2 packages failed to build:
  • octavePackages.communications
  • octavePackages.image
54 packages built:
  • gama
  • minc_widgets
  • octave
  • octavePackages.bim
  • octavePackages.bsltl
  • octavePackages.cgi
  • octavePackages.control
  • octavePackages.data-smoothing
  • octavePackages.database
  • octavePackages.dataframe
  • octavePackages.divand
  • octavePackages.doctest
  • octavePackages.econometrics
  • octavePackages.financial
  • octavePackages.fits
  • octavePackages.fpl
  • octavePackages.fuzzy-logic-toolkit
  • octavePackages.ga
  • octavePackages.general
  • octavePackages.generate_html
  • octavePackages.geometry
  • octavePackages.instrument-control
  • octavePackages.interval
  • octavePackages.io
  • octavePackages.linear-algebra
  • octavePackages.lssa
  • octavePackages.ltfat
  • octavePackages.mapping
  • octavePackages.matgeom
  • octavePackages.miscellaneous
  • octavePackages.msh
  • octavePackages.mvn
  • octavePackages.nan
  • octavePackages.ncarray
  • octavePackages.netcdf
  • octavePackages.nurbs
  • octavePackages.octclip
  • octavePackages.optics
  • octavePackages.optim
  • octavePackages.optiminterp
  • octavePackages.parallel
  • octavePackages.quaternion
  • octavePackages.queueing
  • octavePackages.signal
  • octavePackages.sockets
  • octavePackages.splines
  • octavePackages.statistics
  • octavePackages.stk
  • octavePackages.struct
  • octavePackages.symbolic
  • octavePackages.tsa
  • octavePackages.windows
  • octavePackages.zeromq
  • sundials

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/1171

@SuperSandro2000 SuperSandro2000 merged commit b727af8 into NixOS:master Sep 4, 2022
@tjni tjni deleted the sundials-stackprotector branch September 4, 2022 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

openmpi: build fails on aarch64-darwin
3 participants