python310Packages.twisted: remove pyOpenSSL checkInput on aarch64-darwin#180234
Merged
SuperSandro2000 merged 1 commit intoNixOS:staging-nextfrom Jul 7, 2022
Merged
Conversation
Member
|
I am in favor of this way to handle the pyopenssl issue. The same could be done to urllib3 as well: propagatedBuildInputs = passthru.optional-dependencies.brotli
++ passthru.optional-dependencies.secure;
passthru.optional-dependencies = {
brotli = if isPyPy then [ brotlicffi ] else [ brotli ];
secure = [ certifi cryptography idna pyopenssl ];
socks = [ pysocks ];
}; |
Member
|
We need to target at least staging-next here because we need more fixes from there. |
Member
That got already fixed in staging-next (or maybe still staging) |
d5cbaf0 to
ddcb3f9
Compare
Contributor
Author
|
@SuperSandro2000 - Rebased on |
Member
|
@ofborg build python310Packages.twisted |
Contributor
Author
|
@SuperSandro2000 - Thank you for the assistance here! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
This unbreaks
twisted, and also programs likebupand transitivelygit-annexon aarch64-darwin. An alternative to #179924.Closes #179924
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes