From 9ef62950cba8f539318bdc1707770ef6dd575c45 Mon Sep 17 00:00:00 2001 From: Vincent Laporte Date: Fri, 11 Feb 2022 07:34:59 +0100 Subject: [PATCH 1/3] ocamlPackages.piqi: fix build --- pkgs/development/ocaml-modules/piqi/default.nix | 12 +++--------- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/pkgs/development/ocaml-modules/piqi/default.nix b/pkgs/development/ocaml-modules/piqi/default.nix index 84ccc469f6e57..faeb804d8aa88 100644 --- a/pkgs/development/ocaml-modules/piqi/default.nix +++ b/pkgs/development/ocaml-modules/piqi/default.nix @@ -19,15 +19,9 @@ stdenv.mkDerivation rec { createFindlibDestdir = true; - buildPhase = '' - make - make -C piqilib piqilib.cma - ''; - - installPhase = '' - make install; - make ocaml-install; - ''; + postBuild = "make -C piqilib piqilib.cma"; + + installTargets = [ "install" "ocaml-install" ]; meta = with lib; { homepage = "https://piqi.org"; From d5050e3274edec9a7aeb1f9262e1d3e5f1b8aecb Mon Sep 17 00:00:00 2001 From: Vincent Laporte Date: Fri, 11 Feb 2022 08:18:15 +0100 Subject: [PATCH 2/3] ocamlPackages.piqi-ocaml: fix build --- pkgs/development/ocaml-modules/piqi-ocaml/default.nix | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/pkgs/development/ocaml-modules/piqi-ocaml/default.nix b/pkgs/development/ocaml-modules/piqi-ocaml/default.nix index 9899bfc4bdf9c..590c001c41950 100644 --- a/pkgs/development/ocaml-modules/piqi-ocaml/default.nix +++ b/pkgs/development/ocaml-modules/piqi-ocaml/default.nix @@ -16,7 +16,11 @@ stdenv.mkDerivation rec { createFindlibDestdir = true; - installPhase = "DESTDIR=$out make install"; + installPhase = '' + runHook preInstall + DESTDIR=$out make install + runHook postInstall + ''; meta = with lib; { homepage = "https://piqi.org"; From 7b9b38fb448087786e66323a762bbe13660330e6 Mon Sep 17 00:00:00 2001 From: Vincent Laporte Date: Fri, 11 Feb 2022 09:58:23 +0100 Subject: [PATCH 3/3] ocamlPackages.bap: fix build --- pkgs/development/ocaml-modules/bap/default.nix | 2 ++ 1 file changed, 2 insertions(+) diff --git a/pkgs/development/ocaml-modules/bap/default.nix b/pkgs/development/ocaml-modules/bap/default.nix index 6723ad0c1c81c..f8e07fd1265cb 100644 --- a/pkgs/development/ocaml-modules/bap/default.nix +++ b/pkgs/development/ocaml-modules/bap/default.nix @@ -49,6 +49,7 @@ stdenv.mkDerivation rec { piqi-ocaml uuidm frontc yojson ]; installPhase = '' + runHook preInstall export OCAMLPATH=$OCAMLPATH:$OCAMLFIND_DESTDIR; export PATH=$PATH:$out/bin export CAML_LD_LIBRARY_PATH=''${CAML_LD_LIBRARY_PATH-}''${CAML_LD_LIBRARY_PATH:+:}$OCAMLFIND_DESTDIR/bap-plugin-llvm/:$OCAMLFIND_DESTDIR/bap/ @@ -58,6 +59,7 @@ stdenv.mkDerivation rec { makeWrapper ${utop}/bin/utop $out/bin/baptop --prefix OCAMLPATH : $OCAMLPATH --prefix PATH : $PATH --add-flags "-ppx ppx-bap -short-paths -require \"bap.top\"" wrapProgram $out/bin/bapbuild --prefix OCAMLPATH : $OCAMLPATH --prefix PATH : $PATH ln -s $sigs $out/share/bap/sigs.zip + runHook postInstall ''; disableIda = "--disable-ida";