From 1154a4422f6cff24cde2d98df372d2e582e32f76 Mon Sep 17 00:00:00 2001 From: Frederik Rietdijk Date: Sun, 1 Nov 2020 17:53:43 +0100 Subject: [PATCH 1/3] kdenlive: avoid double wrapping --- pkgs/applications/kde/kdenlive.nix | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/pkgs/applications/kde/kdenlive.nix b/pkgs/applications/kde/kdenlive.nix index 795ba87ad5b59..8be6ef88e64a9 100644 --- a/pkgs/applications/kde/kdenlive.nix +++ b/pkgs/applications/kde/kdenlive.nix @@ -84,12 +84,20 @@ mkDerivation { sed -i CMakeLists.txt -e '/find_package(Qt5 REQUIRED/ s|)| Concurrent)|' substituteAllInPlace src/kdenlivesettings.kcfg ''; + + dontWrapGApps = true; + # Frei0r path needs to be set too or Kdenlive will complain. See: # https://github.com/NixOS/nixpkgs/issues/83885 # https://github.com/NixOS/nixpkgs/issues/29614#issuecomment-488849325 qtWrapperArgs = [ "--set FREI0R_PATH ${frei0r}/lib/frei0r-1" ]; + + preFixup = '' + qtWrapperArgs+=("''${gappsWrapperArgs[@]}") + ''; + meta = { license = with lib.licenses; [ gpl2Plus ]; }; From ed2d393c183815deb051b80fc5c697545238b97f Mon Sep 17 00:00:00 2001 From: Frederik Rietdijk Date: Sun, 1 Nov 2020 17:54:20 +0100 Subject: [PATCH 2/3] kdenlive: depend on qtmultimedia instead of unsupported qtwebkit --- pkgs/applications/kde/kdenlive.nix | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pkgs/applications/kde/kdenlive.nix b/pkgs/applications/kde/kdenlive.nix index 8be6ef88e64a9..b2abee5793962 100644 --- a/pkgs/applications/kde/kdenlive.nix +++ b/pkgs/applications/kde/kdenlive.nix @@ -25,9 +25,9 @@ , frei0r , phonon-backend-gstreamer , qtdeclarative +, qtmultimedia , qtquickcontrols2 , qtscript -, qtwebkit , rttr , kpurpose , kdeclarative @@ -60,9 +60,9 @@ mkDerivation { mlt phonon-backend-gstreamer qtdeclarative + qtmultimedia qtquickcontrols2 qtscript - qtwebkit shared-mime-info libv4l ffmpeg-full From c26dc4608dafbedcb65827fe37f836c73010900c Mon Sep 17 00:00:00 2001 From: Frederik Rietdijk Date: Sun, 1 Nov 2020 17:55:34 +0100 Subject: [PATCH 3/3] libsForQt515.mlt: is not broken --- pkgs/development/libraries/mlt/qt-5.nix | 1 - 1 file changed, 1 deletion(-) diff --git a/pkgs/development/libraries/mlt/qt-5.nix b/pkgs/development/libraries/mlt/qt-5.nix index 3dcbda68135f3..f1ed04aa9bca8 100644 --- a/pkgs/development/libraries/mlt/qt-5.nix +++ b/pkgs/development/libraries/mlt/qt-5.nix @@ -69,6 +69,5 @@ stdenv.mkDerivation rec { license = licenses.gpl3; maintainers = [ maintainers.goibhniu ]; platforms = platforms.linux; - broken = versionAtLeast qtbase.version "5.15"; }; }