Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

buildbot broken by pylint upgrade #45782

Closed
ian-ross opened this issue Aug 30, 2018 · 9 comments
Closed

buildbot broken by pylint upgrade #45782

ian-ross opened this issue Aug 30, 2018 · 9 comments
Labels
0.kind: regression Something that worked before working no longer 6.topic: python

Comments

@ian-ross
Copy link

Issue description

Following this commit to upgrade pylint, buildbot no longer builds -- it uses Python 2.7, depends on pylint, and the latest pylint has disabled = pythonOlder "3.4".

Steps to reproduce

Try to install the buildbot package.

Technical details

  • system: "x86_64-linux"
  • host os: Linux 4.18.5-arch1-1-ARCH, Arch Linux, noversion
  • multi-user?: no
  • sandbox: no
  • version: nix-env (Nix) 2.0.4
  • channels(iross): "nixpkgs-18.09pre149415.8395f9aa85e"
  • nixpkgs: /home/iross/.nix-defexpr/channels/nixpkgs
@vcunat vcunat added 6.topic: python 0.kind: regression Something that worked before working no longer labels Aug 30, 2018
@vcunat
Copy link
Member

vcunat commented Aug 30, 2018

/cc @dotlambda, @FRidh.

@dotlambda
Copy link
Member

It seems like it's time to move buildbot to python3: #45789.

@ian-ross
Copy link
Author

Wow. That was an awesomely quick response. Thanks, @dotlambda!

@lopsided98
Copy link
Contributor

lopsided98 commented Aug 30, 2018

Pylint 1.8/1.9 is still maintained until 2020, so that is an alternative to maintain Python 2 support.

@vcunat
Copy link
Member

vcunat commented Aug 30, 2018

Regardless, I wouldn't delay migration to python3 as the default without a good reason, even if the official un-supporting is still a bit over a year away.

@lopsided98
Copy link
Contributor

Moving exclusively to Python 3 has the potential to break configurations, because they are written in Python. This might be fine, but we should be aware of it. See #45789 for more of this discussion.

@dotlambda
Copy link
Member

I think we should provide indeed provide pylint 1.9 as python2Packages.pylint until support ends. I also think we should move buildbot to pythonPackages as @FRidh suggested.
@lopsided98 Do you want to continue my work?

@FRidh
Copy link
Member

FRidh commented Aug 30, 2018

Please discuss ideas/plans and such on the issue (#45789), not the PR.

@lopsided98
Copy link
Contributor

#45890 was merged a while ago, so this issue is resolved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.kind: regression Something that worked before working no longer 6.topic: python
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants