-
-
Notifications
You must be signed in to change notification settings - Fork 13.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
browserpass does not taltk to firefox 57 #33748
Comments
You can work around it by linking the firefox manifest from
Relevant Firefox bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1318461 |
This was fixed in #31743 by a Nixpkgs option. Maybe |
I never managed to make it work either so thanks @ttuegel for the pointer. I believe home-manager installs it in ~/.mozilla so that could work too. |
So this is fixable, the fix was not straightforward but it is going to be fixed in 18.03? |
Yeah, disregard my comment above (nixpkgs patch around the firefox issue). If I understand correctly you want to do something like this in nixpkgs.config.firefox.enableBrowserPass = true; |
I'm experiencing this same issue with firefox 59.0.1. I have tried both firefox-bin and firefox. I'm mostly using firefox-bin because I like the Mozilla branding, but it doesn't matter that much really. I have added I've just started google-chrome up to test there and that seems to work. But that won't help me that much in firefox 😄 output from nix-info: |
Ok,I've got it working and did some research. The first issue I've had which was really odd to me was that I had the wrong firefox extension, it has been working before. The only thing I can assume made it that way is that they released a separate extension when it became webextensions or something. But that doesn't make very much sense to me since the button was there in the browser. So my first step to get this to work in firefox again was to remove the old one and install this one: https://addons.mozilla.org/en-US/firefox/addon/browserpass-ce/ (link is in README of browserpass github page). I've also not managed to get it to work (in firefox) with the service for browserpass ( |
So this is still broken. Using browserpass-ce I get the suggestions but when clicking on them, it only displays "Error: An unexpected error occurred". Will this be fixed? |
This works for me with |
Hmmh. Installed via |
@wucke13 Could you try repeating this with the browser console open? (Ctrl-Shift-J to open the browser console.) That may give a more detailed error message. |
Thats the output. |
@wucke13 Do you have gpg in your system-packages or not? I'd say that it shouldn't be needed, but might be needed. |
No, I don't have it explicitly installed, but I have |
If I look in the browserpass source, I found this function: https://github.com/dannyvankooten/browserpass/blob/4ca5c7c0d557f4aece063da54683eb04436d59be/browserpass.go#L135-L155 Which seems to be the one that failed. It's purpose seems to be to find a gpg binary. But it fails since it's not in your environment. If I look in our package for browserpass https://github.com/NixOS/nixpkgs/blob/fbac1cbc06568380b538e81546e9d3b1715cab14/pkgs/tools/security/browserpass/default.nix -- I don't see that we patch the path to the gpg binary, which means that it must exist in the system environment for browserpass to find it. A temporary fix for you would be to add But in reality browserpass should be patched with our path to gpg. |
The temporary fix does work for me. Closing since you started a PR on this. Great thanks! |
Issue description
With
firefox-57
,browserpass
does not work properly. When clicking on the browserpass icon in firefox, browserpass states 'Error talking to browserpass'Steps to reproduce
programs.browserpass.enable = true
environment.systemPackages = with pkgs; [ firefox ]
Technical details
"x86_64-linux"
Linux 4.14.9, NixOS, 17.09.2498.a9ffb7b0b5a (Hummingbird)
yes
no
nix-env (Nix) 1.11.16
"nixos-17.09.2498.a9ffb7b0b5a"
"nixpkgs-18.03pre121983.fd7953d95f4"
/nix/var/nix/profiles/per-user/root/channels/nixos/nixpkgs
The text was updated successfully, but these errors were encountered: