-
-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build failure: dooit #330380
Comments
If you do not ping listed maintainers for Ping: Log with full chain:
I assume from this fix for diff --git a/pkgs/by-name/do/dooit/package.nix b/pkgs/by-name/do/dooit/package.nix
index ea549fff7196..bdc54b3f5dee 100644
--- a/pkgs/by-name/do/dooit/package.nix
+++ b/pkgs/by-name/do/dooit/package.nix
@@ -1,11 +1,14 @@
{ lib
, fetchFromGitHub
, dooit
-, python3
+, python311
, testers
, nix-update-script
}:
+let
+ python3 = python311;
+in
python3.pkgs.buildPythonApplication rec {
pname = "dooit";
version = "2.2.0"; |
Oh, sorry, I made a mistake with the formatting when I mentioned the package maintainer, I left it in the comment |
Sorry, I forgot to come back to this... I was trying to see if I could fix textual/tree-sitter-languages/tree-sitter0_21 chain with python312. We can pin to 311 in the meantime. |
That one seems to be relatively simple too tree-sitter0_21 patchdiff --git a/pkgs/development/python-modules/tree-sitter0_21/default.nix b/pkgs/development/python-modules
index 665f7d6b56ce..76eaee6b0cba 100644
--- a/pkgs/development/python-modules/tree-sitter0_21/default.nix
+++ b/pkgs/development/python-modules/tree-sitter0_21/default.nix
@@ -4,8 +4,8 @@
fetchFromGitHub,
pytestCheckHook,
pythonOlder,
- pythonAtLeast,
setuptools,
+ fetchpatch2,
}:
buildPythonPackage rec {
@@ -13,8 +13,7 @@ buildPythonPackage rec {
version = "0.21.3";
pyproject = true;
- # https://github.com/tree-sitter/py-tree-sitter/issues/209
- disabled = pythonAtLeast "3.12" || pythonOlder "3.7";
+ disabled = pythonOlder "3.7";
src = fetchFromGitHub {
owner = "tree-sitter";
@@ -24,10 +23,20 @@ buildPythonPackage rec {
fetchSubmodules = true;
};
+ # https://github.com/tree-sitter/py-tree-sitter/pull/214
+ patches = [
+ (fetchpatch2 {
+ url = "https://github.com/tree-sitter/py-tree-sitter/commit/80d3cae493c4a47e49cc1d2ebab0a8eaf7617825.patch?full_index=1";
+ hash = "sha256-RqZGdUwfX04ICHZNvPbWZiuNI15RPlJkVfW17k6V7iA=";
+ })
+ ];
+
build-system = [ setuptools ];
nativeCheckInputs = [ pytestCheckHook ];
+ dependencies = [ setuptools ];
+
pythonImportsCheck = [ "tree_sitter" ];
preCheck = '' It was not accepted upstream, but they fully changed these parts around v0.23 so there is no |
Steps To Reproduce
Steps to reproduce the behavior:
Build log
Additional context
I use nixos-unstable. NixVim and Helix with tree-sitter are not the cause of an issue, I can do a rebuild with them, error occurs then I add dooit.
Notify maintainers
Metadata
Please run
nix-shell -p nix-info --run "nix-info -m"
and paste the result.Add a 👍 reaction to issues you find important.
The text was updated successfully, but these errors were encountered: