Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update request: teams-for-linux 1.4.27 → 1.7.4 #322636

Closed
1 task done
xdinterface opened this issue Jun 26, 2024 · 5 comments
Closed
1 task done

Update request: teams-for-linux 1.4.27 → 1.7.4 #322636

xdinterface opened this issue Jun 26, 2024 · 5 comments
Labels
9.needs: package (update) This needs a package to be updated

Comments

@xdinterface
Copy link

xdinterface commented Jun 26, 2024

  • Package name: teams-for-linux
  • Latest released version: 1.7.4
  • Current version on the unstable channel: 1.4.27
  • Current version on the stable/release channel: 1.4.27

Notify maintainers
@muscaln
@lilyinstarlight
@qjoly
@chvp


Note for maintainers: Please tag this issue in your PR.


Add a 👍 reaction to issues you find important.

@ShamrockLee
Copy link
Contributor

ShamrockLee commented Jul 14, 2024

@Julien76 How do you package teams-for-linux 1.7.4?

The upstream moves back to NPM package-lock.json in IsmaelMartinez/teams-for-linux#1284 and in release 1.6.0, meaning we need to rewrite this package's Nix expression.

@Julien76
Copy link

@ShamrockLee,
I tried building using npm or converting the npm lock file to a yarn.lock but every time the build was failing due to some electron dependency issues.

So in the end, I built it against the appImage as follow:

{
  pkgs,
  lib,
  ...
}: let
  teams-for-linux-updated = pkgs.appimageTools.wrapType2 rec {
    name = "teams-for-linux";
    src = pkgs.fetchurl {
      url = "https://github.com/IsmaelMartinez/teams-for-linux/releases/download/v1.7.4/teams-for-linux-1.7.4.AppImage";
      hash = "sha256-A4RgpUeC8W5aHEZ/CrjZIVYvkynpfs015Kxo2XlNtlE=";
    };

    desktopItems = [
      (pkgs.makeDesktopItem {
        inherit name;
        exec = name;
        icon = name;
        desktopName = "Microsoft Teams for Linux";
        comment = meta.description;
        categories = ["Network" "InstantMessaging" "Chat"];
      })
    ];

    meta = {
      description = "Unofficial Microsoft Teams client for Linux";
      mainProgram = name;
      homepage = "https://github.com/IsmaelMartinez/teams-for-linux";
      license = lib.licenses.gpl3Only;
      maintainers = with lib.maintainers; [muscaln lilyinstarlight qjoly chvp];
      platforms = lib.platforms.unix;
    };
  };
in {
  home.packages = with pkgs; [
    teams-for-linux-updated
  ];

  xdg.desktopEntries."teams-for-linux" = {
    name = "Microsoft Teams for Linux";
    comment = "Team communication and collaboration software";
    icon = "teams-for-linux";
    type = "Application";
    exec = ''env XDG_CURRENT_DESKTOP="" ${pkgs.teams-for-linux}/bin/teams-for-linux %U'';
    categories = ["Network" "InstantMessaging" "Chat"];
    terminal = true;
  };

  # Add the configuration file for teams-for-linux
  xdg.configFile."teams-for-linux/config.json".source = ./config.json;
}

please not that I'm quite new to Nix and I might have done something wrong while trying to build with npm or yarn. Also I used this expression with home-manager so I'm not sure how it'll work without it.

@michelealbrigo
Copy link

michelealbrigo commented Aug 29, 2024

Bumping this up, because since today, unstable is not building anymore with teams-on-linux package, because it carries version 29.4.6 of electron, now marked as EOL.

Known issues:
        - Electron version 29.4.6 is EOL

Workaround available by permitting it as insecure package.
Edit: workaround not working around for me: package does not build. I disabled the package and went to Thunderbird + OWL in the meantime

@VincentBerthier
Copy link

I have the same problem unfortunately.

@DamienCassou
Copy link
Contributor

Fixed in #337868.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
9.needs: package (update) This needs a package to be updated
Projects
None yet
Development

No branches or pull requests

6 participants