-
-
Notifications
You must be signed in to change notification settings - Fork 15.4k
Temporary ABI incompatibility between plugins built for upstream rofi and rofi-wayland #298539
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Can I do something on distro other than NixOS or it is better just to wait? |
For other distros, you can build rofi-calc from source using rofi-wayland headers, or probably downgrade rofi-wayland to version 1.7.5+wayland1, but the latter is untested and you may run into other issues that are fixed with recent versions. |
This comment has been minimized.
This comment has been minimized.
A collision is likely due to different derivations of rofi being used in your configuration, which is not this issue: /nix/store/yi64...-rofi-1.7.5+wayland3/bin/rofi In this case, you may have references to |
This issue has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/rofi-calc-not-working-with-rofi-wayland/51301/2 |
This issue has mostly been fixed by the rofi-wayland 1.7.7+wayland1 release in unstable, so this can be closed if preemptive measures are not planned for nixpkgs. |
Describe the bug
Plugins that are built for release rofi (1.7.5) are ABI incompatible with rofi-wayland (1.7.5+wayland2/3) until the next upstream release, resulting in runtime errors when attempting to run rofi with those plugins enabled (namely rofi-calc):
Those plugins need to be built against rofi-wayland instead of upstream rofi. This can be worked around in nixpkgs by overriding the rofi-unwrapped package in the plugin module:
Steps To Reproduce
rofi -modes calc -show calc
in terminalExpected behavior
Additional context
This is more a reference for those encountering the bug than an actionable issue.
The incompatibility should only last until the next rofi release, but something of this nature that requires different build inputs for plugins may occur again in the future considering that rofi-wayland strays behind upstream by design. In which case, anything that can be done through nixpkgs would be welcome, though home-manager seems like it would be the best place to handle that as it already exposes options for plugins.
Notify maintainers
rofi(-wayland): @bew
rofi-calc: @luc65r @albakham
Metadata
Add a 👍 reaction to issues you find important.
The text was updated successfully, but these errors were encountered: