Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update request: lightningcss 1.24.0 → 1.24.1 #296639

Closed
1 task done
toastal opened this issue Mar 17, 2024 · 4 comments · Fixed by #302174
Closed
1 task done

Update request: lightningcss 1.24.0 → 1.24.1 #296639

toastal opened this issue Mar 17, 2024 · 4 comments · Fixed by #302174
Labels
6.topic: rust 9.needs: package (update) This needs a package to be updated

Comments

@toastal
Copy link
Contributor

toastal commented Mar 17, 2024

  • Package name: lightningcss
  • Latest released version: 1.24.1
  • Current version on the unstable channel: 1.22.0
  • Current version on the stable/release channel: 1.24.0

Notify maintainers

myself, @toastal


Note for maintainers: Despite being a minor version bump, an entire dependency chain was added for NAPI which I think has something to do with WASM which fails the cargo-auditable test in Nix. See lightningcss’s open bug on their Microsoft GitHub proprietary issue tracker @ parcel-bundler/lightningcss#702 As a non-Rust developer, I have no idea what this error is supposed to mean with its Cargo package management. Hopefully their maintainer will eventually have a look.


Add a 👍 reaction to issues you find important.

1

Footnotes

  1. Please consider giving up MS GitHub or offering a non-proprietary, non-US-corporate-controlled mirror for this free software project.
    I wish to delete this Microsoft account in the future, but I need more projects like this to support alternative methods to send patches & contribute.

@toastal toastal added the 9.needs: package (update) This needs a package to be updated label Mar 17, 2024
@JohnRTitor
Copy link
Contributor

Build error when updating:

thread 'main' panicked at cargo-auditable/src/collect_audit_data.rs:77:9:
cargo metadata failure: error: Package `lightningcss-napi v0.1.0 (/build/source/napi)` does not have feature `rayon`. It has an optional dependency with that name, but that dependency uses the "dep:" syntax in the features table, so it does not have an implicit feature with that name.

note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
error: could not compile `lightningcss` (bin "lightningcss")

@toastal
Copy link
Contributor Author

toastal commented Apr 5, 2024

@JohnRTitor Personally I’ve stuck with version 1.23.0 since 1.24.0 had a regression for system colors. The upstream maintainer seems to be too busy with other stuff to look into issues.

@JohnRTitor
Copy link
Contributor

parcel-bundler/lightningcss#713 should fix it for further releases. For this particular 1.24.1 release, I added a patch to automatically patch the source, see #302174

@toastal
Copy link
Contributor Author

toastal commented Apr 10, 2024

@JohnRTitor great work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: rust 9.needs: package (update) This needs a package to be updated
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants