-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
meson: add soversion with nix version to give SONAME to libs #13995
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hmm not good enough for MacOS: |
|
A simple workaround would be to remove the |
|
What's the use case for having a more fine grined version here? |
|
People were complaining that an integer SONAME version was misleading or giving expectations of API stability. |
…3960, NixOS#13979) remove 'pre' version suffix for non-releases (chokes Darwin ld)
|
Fedora test build: https://koji.fedoraproject.org/koji/taskinfo?taskID=137146842 An alternative to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and macOS / Linux look as expected.
% ls -la /nix/store/jk51fi97yrwl3grj97pv7gnl3ks3hxq0-nix-util-2.32.0pre/lib/
lrwxrwxrwx - root 55 years [libnixutil.so](http://libnixutil.so/) -> [libnixutil.so](http://libnixutil.so/).2.32.0
.r-xr-xr-x 2.0M root 55 years [libnixutil.so](http://libnixutil.so/).2.32.0
0x000000000000000e (SONAME) Library soname: [[libnixutil.so](http://libnixutil.so/).2.32.0]
% ls -la
.r-xr-xr-x 4.8M root 55 years libnixstore.2.32.0.dylib
lrwxrwxrwx - root 55 years libnixstore.dylib -> libnixstore.2.32.0.dylib
xokdvium
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SGTM. Would be nice to deduplicate some of the code into nix-meson-build-support though
Okay I try a followup PR for that - good point edit: see PR #14001 |
This is a follow-on to NixOS#13995 which added soversion to the libraries
Maybe this is more acceptable? It makes the
soversionequal to the nix version.See discussions in #13960 and #13979 etc