Skip to content

Conversation

@xokdvium
Copy link
Contributor

@xokdvium xokdvium commented Mar 22, 2025

We want the $doc, $man outputs to be symlinks pointing to nix-manual and
nix-manual.man. Creating the directories first makes the ln command
produce symlink $doc/${nix-manual} instead.

$file /nix/store/q4dwlnd36gpfajgfcp6hca2xwy068wjq-nix-2.27.1-man/rwh8ky3k040wyrywl8k2v5b3csdfbdg7-nix-manual-2.27.1-man

/nix/store/q4dwlnd36gpfajgfcp6hca2xwy068wjq-nix-2.27.1-man/rwh8ky3k040wyrywl8k2v5b3csdfbdg7-nix-manual-2.27.1-man:
symbolic link to /nix/store/rwh8ky3k040wyrywl8k2v5b3csdfbdg7-nix-manual-2.27.1-man

This is the reason nix-env --help is once again broken on 2.26/2.27/master after 4108529.

Motivation

Context

#12582
#12382

Can we please backport this to 2.26 and 2.27?

cc @roberth


Add 👍 to pull requests you find important.

The Nix maintainer team uses a GitHub project board to schedule and track reviews.

@xokdvium xokdvium requested a review from edolstra as a code owner March 22, 2025 11:36
We want the $doc, $man outputs to be symlinks pointing to nix-manual and
nix-manual.man. Creating the directories first makes the `ln` command
produce symlink $doc/${nix-manual} instead.

```
$file /nix/store/q4dwlnd36gpfajgfcp6hca2xwy068wjq-nix-2.27.1-man/rwh8ky3k040wyrywl8k2v5b3csdfbdg7-nix-manual-2.27.1-man

/nix/store/q4dwlnd36gpfajgfcp6hca2xwy068wjq-nix-2.27.1-man/rwh8ky3k040wyrywl8k2v5b3csdfbdg7-nix-manual-2.27.1-man:
  symbolic link to /nix/store/rwh8ky3k040wyrywl8k2v5b3csdfbdg7-nix-manual-2.27.1-man
```

This is the reason `nix-env --help` is once again broken on 2.26/2.27/master
after 4108529.
@xokdvium xokdvium force-pushed the fix-man-doc-outputs branch from 4869335 to 0ddfbc5 Compare March 22, 2025 12:17
@roberth roberth merged commit bfc05d2 into NixOS:master Mar 23, 2025
13 checks passed
@xokdvium xokdvium deleted the fix-man-doc-outputs branch March 23, 2025 11:53
@roberth
Copy link
Member

roberth commented Mar 23, 2025

I can't believe I didn't find my mistake.
Thank you!

mergify bot added a commit that referenced this pull request Mar 23, 2025
…2723

packaging/everything.nix: Fix doc and man outputs (backport #12723)
mergify bot added a commit that referenced this pull request Mar 23, 2025
…2723

packaging/everything.nix: Fix doc and man outputs (backport #12723)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants