-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace call to stat
, lstat
, and maybeLstat
with appropriate functions from std::filesystem
#10937
base: master
Are you sure you want to change the base?
Commits on Jun 15, 2024
-
replace some usage of the
stat
andlstat
......with `std::filesystem` functions The `stat` defined in `file-system.cc` is not used anywhere now. This will be removed with the removal of the `STAT` macro defined in the same file. `lstat` is still used in some places so we cannot remove the `STAT` macro.
Configuration menu - View commit details
-
Copy full SHA for 9644910 - Browse repository at this point
Copy the full SHA 9644910View commit details
Commits on Jun 16, 2024
-
the `maybeLstat` is removed in favor of the new `maybeSymlinkStat` which uses the `std::filesystem` library. All the call sites have been updated
Configuration menu - View commit details
-
Copy full SHA for f47743c - Browse repository at this point
Copy the full SHA f47743cView commit details
Commits on Jun 19, 2024
-
remove usage of
lstat
with std::filesystem or...... `unix::lstat` appropriate functions from `std::filesystem` is used in places where `lstat` was called. Places that require platform specific implementation are using `unix::lstat` for now.
Configuration menu - View commit details
-
Copy full SHA for adfee1a - Browse repository at this point
Copy the full SHA adfee1aView commit details -
fix: handle
srcFile
not_found
correctly- The `std::filesystem::status` returns `not_found` and does not throw any error. - `std::filesystem::*` is shortened to `fs::*` for better readability
Configuration menu - View commit details
-
Copy full SHA for 63f5288 - Browse repository at this point
Copy the full SHA 63f5288View commit details -
revert
PosixSourceAccessor::cachedLstat
The result of this function cannot be `std::filesystem::file_status` yet as we use it to acess `st_mtime`. The equivalent function in `std::filesystem` to get the last write time does follow symlinks which is not the behavior we want.
Configuration menu - View commit details
-
Copy full SHA for 6694d5d - Browse repository at this point
Copy the full SHA 6694d5dView commit details -
fix: wrong argument in a call to
fs::permissions
A typo (`"src" -> "dst"`) caught by functional tests is fixed
Configuration menu - View commit details
-
Copy full SHA for f410986 - Browse repository at this point
Copy the full SHA f410986View commit details
Commits on Jun 20, 2024
-
The removed `nix::maybeLstat` was referenced here. It's replaced with the new function that replaced it.
Configuration menu - View commit details
-
Copy full SHA for ad2525a - Browse repository at this point
Copy the full SHA ad2525aView commit details
Commits on Jun 26, 2024
-
Configuration menu - View commit details
-
Copy full SHA for c47c156 - Browse repository at this point
Copy the full SHA c47c156View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1310083 - Browse repository at this point
Copy the full SHA 1310083View commit details
Commits on Jul 11, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 749c037 - Browse repository at this point
Copy the full SHA 749c037View commit details -
Configuration menu - View commit details
-
Copy full SHA for e0090fe - Browse repository at this point
Copy the full SHA e0090feView commit details