-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Autodetect NAR compression #4534
Comments
It might be helpful to upload the NAR files with the Content-Encoding header set, for that purpose. That way it's possible to query the compression without downloading the file and looking for magic headers. Or use the Content-Type. S3 supports recording both of those (as does Google Storage). |
That would only work for HTTP, but we shouldn't need it since the first few bytes allow the compression method to be detected. Hopefully we can use libarchive for this (see #3333). |
Brotli seems to have no standardized framing format, according to google/brotli#298 and the followup questions. I wonder if we still want to keep support for uploading, and if so, strongly discourage using it in places where we can't set the Content-Type to facilitate the format detection. |
I marked this as stale due to inactivity. → More info |
Followup to #4464. Re-uploading a NAR with a different compression method invalidates the (cached) .narinfo, so it's better if we get rid of the
Compression
field and autodetect the compression method.The text was updated successfully, but these errors were encountered: