Skip to content

Commit 3ef9c79

Browse files
Radvendiixokdvium
andcommitted
Apply suggestions from code review
Co-authored-by: Sergei Zimmerman <[email protected]>
1 parent ed9f61d commit 3ef9c79

File tree

1 file changed

+1
-6
lines changed

1 file changed

+1
-6
lines changed

src/libexpr/include/nix/expr/nixexpr.hh

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@ std::string showAttrPath(const SymbolTable & symbols, const AttrPath & attrPath)
8585

8686
using UpdateQueue = SmallTemporaryValueVector<conservativeStackReservation>;
8787

88-
struct Exprs
88+
class Exprs
8989
{
9090
std::pmr::monotonic_buffer_resource buffer;
9191
public:
@@ -205,11 +205,6 @@ struct ExprString : Expr
205205
v.mkStringNoCopy(s);
206206
};
207207

208-
~ExprString()
209-
{
210-
// String is allocated in an arena
211-
}
212-
213208
Value * maybeThunk(EvalState & state, Env & env) override;
214209
COMMON_METHODS
215210
};

0 commit comments

Comments
 (0)