Correct bound on prevWith

Radvendii · Ericson2314 · web-flow · commit 36e4e19442d8 · 2025-11-03T18:44:27.000+01:00
Co-authored-by: John Ericson &lt;git@JohnEricson.me&gt;
diff --git a/src/libexpr/nixexpr.cc b/src/libexpr/nixexpr.cc
@@ -523,7 +523,7 @@ void ExprWith::bindVars(EvalState & es, const std::shared_ptr<const StaticEnv> &
     prevWith = 0;
     for (curEnv = env.get(), level = 1; curEnv; curEnv = curEnv->up.get(), level++)
         if (curEnv->isWith) {
-            assert(level < std::numeric_limits<uint32_t>::max());
+            assert(level <= std::numeric_limits<uint32_t>::max());
             prevWith = level;
             break;
         }

Original file line number	Diff line number	Diff line change
`@@ -523,7 +523,7 @@ void ExprWith::bindVars(EvalState & es, const std::shared_ptr<const StaticEnv> &`
`523`	`523`	`prevWith = 0;`
`524`	`524`	`for (curEnv = env.get(), level = 1; curEnv; curEnv = curEnv->up.get(), level++)`
`525`	`525`	`if (curEnv->isWith) {`
`526`		`- assert(level < std::numeric_limits<uint32_t>::max());`
	`526`	`+ assert(level <= std::numeric_limits<uint32_t>::max());`
`527`	`527`	`prevWith = level;`
`528`	`528`	`break;`
`529`	`529`	`}`