Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax dependency on spsdk to allow using 2.1.x? #528

Closed
johanneskastl opened this issue Apr 13, 2024 · 2 comments · Fixed by #533
Closed

Relax dependency on spsdk to allow using 2.1.x? #528

johanneskastl opened this issue Apr 13, 2024 · 2 comments · Fixed by #533

Comments

@johanneskastl
Copy link

Currently spsdk is pinned to<2.1 in the pyproject.toml file.

Could this be relaxed, to allow using versions 2.1.x? I had a quick glance and found lots of doc changes between 2.0.x and 2.1.x, but not many real code changes. If spsdk uses semantic versioning, there should not be major / breaking changes in those versions.

Thanks in advance!

Johanes

@robin-nitrokey
Copy link
Member

Unfortunately, spsdk does not follow semver, see nxp-mcuxpresso/spsdk#34, and 2.1 is indeed a breaking change, see #524. The next pynitrokey release will fix this, either by merging the linked PR to make it compatible with spsdk 2.1, or by vendoring the required components of spsdk directly in pynitrokey, see #519.

@johanneskastl
Copy link
Author

Thanks a lot @robin-nitrokey that was quick! :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants