Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tagging scheme broken #44

Closed
dvzrv opened this issue Sep 26, 2020 · 4 comments
Closed

Tagging scheme broken #44

dvzrv opened this issue Sep 26, 2020 · 4 comments
Assignees

Comments

@dvzrv
Copy link

dvzrv commented Sep 26, 2020

Hi! I would like to package pynitrokey for Arch Linux.
Unfortunately the tagging scheme is now broken with using v0.4 instead of v0.4.nitrokey, as there are upstream solo-python related tags and nitrokey related tags in use in this repository and I am using a regular expression match against the nitrokey specific suffix.

Will tags from now on not have the suffixes anymore?
If not, please tag v0.4 also as v4.0.nitrokey.
Thanks!

@szszszsz
Copy link
Member

Hi! Thank you for noticing that!
Indeed, I think it should be 0.4.0.nitrokey, so we would not conflict with upstream's tags. Same scheme is used with Nitrokey FIDO2. What's your view @daringer?

@daringer
Copy link
Collaborator

oops, yeah brings us to the whole "not being a fork anymore topic" ... but that's a second topic, will release a v0.4.1.nitrokey with some recent fixes (including #43) today. Then asap bring the fork topic to a higher prio...

@daringer daringer self-assigned this Sep 27, 2020
@daringer
Copy link
Collaborator

Released 0.4.1 using tag: v0.4.1.nitrokey

@dvzrv
Copy link
Author

dvzrv commented Oct 31, 2020

https://www.archlinux.org/packages/community/any/python-pynitrokey/

@dvzrv dvzrv closed this as completed Oct 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants