Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NFC, FIDO2: Transaction failed #7

Open
robin-nitrokey opened this issue Sep 12, 2022 · 6 comments
Open

NFC, FIDO2: Transaction failed #7

robin-nitrokey opened this issue Sep 12, 2022 · 6 comments

Comments

@robin-nitrokey
Copy link
Member

robin-nitrokey commented Sep 12, 2022

When running the FIDO2 test suite over NFC, the run fails after approx. 2/3 of the tests – e. g. at test_initialize or test_restore – with a Transaction failed error. I also encountered this error in my previous tests occasionally without being able to narrow it down.

Environment:

  • tests 871460
  • firmware 9343983 with DEVELOP=1 and updated to use fido-authenticator v0.1.1
  • REAL_HARDWARE=1 TRANSPORT=FIDO2

report

@szszszsz
Copy link
Member

Can you try running setup_session and the failed tests then?

@szszszsz
Copy link
Member

Perhaps it's worth making the test_suite working with https://pypi.org/project/pytest-randomly/

@robin-nitrokey
Copy link
Member Author

Another run, nearly made it:

Full run

======================================= short test summary info ========================================
FAILED test_comm.py::test_pin_set - smartcard.Exceptions.CardConnectionException: Failed to transmit ...
FAILED test_comm.py::test_pin_change - fido2.ctap.CtapError: CTAP error: 0x7F - OTHER                   
FAILED test_comm.py::test_configure - fido2.ctap.CtapError: CTAP error: 0x7F - OTHER                    
==================================== 3 failed, 66 passed in 34.66s =====================================

webcrypt-fido2-nfc-1.zip

Reduced run

env REAL_HARDWARE=1 TRANSPORT=FIDO2 pipenv run pytest --hardware test_comm.py --template=html1/index.html --report=report-fido2.html -k "test_setup_session or test_pin_set"
====================================== short test summary info ========================================
FAILED test_comm.py::test_pin_set - smartcard.Exceptions.CardConnectionException: Failed to transmit ...
============================== 1 failed, 2 passed, 66 deselected in 1.77s ==============================

webcrypt-fido2-nfc-2.zip

@robin-nitrokey
Copy link
Member Author

robin-nitrokey commented Sep 20, 2022

Observation: The Transaction failed error always occurs if logging is enabled, so it might be due to a timeout.

@robin-nitrokey
Copy link
Member Author

Can no longer reproduce, see #9 for an example run over NFC without failures (except for one outdated test case).

@robin-nitrokey
Copy link
Member Author

Still occurs occasionally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants