Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NK3Mini: UP is not properly aborted #199

Closed
daringer opened this issue Mar 15, 2023 · 2 comments · Fixed by #272
Closed

NK3Mini: UP is not properly aborted #199

daringer opened this issue Mar 15, 2023 · 2 comments · Fixed by #272
Assignees
Labels
app:fido bug Something isn't working

Comments

@daringer
Copy link
Collaborator

It looks like once a User Presence request is started it can only time-out, but if an abort is requested it will not abort. A directly following 2nd UP request will lead to a "busy channel"

To reproduce, e.g. on Gitlab:

  1. click "set up new device"
  2. (you see the device asking for UP)
  3. click "cancel" in the browser
  4. the nk3mini still has the LED active
  5. click "set up new device" again
  6. confirm UP
  7. nothing happens
  8. "busy channel" (I suspect the device panics)

aborting works good for the NK3AN (the LED stops and no busy channel)

@robin-nitrokey
Copy link
Member

Interesting that it works with the NK3AN, cf. #47. Or is this something different?

@daringer
Copy link
Collaborator Author

I could also imagine that this is originating in the user presence hardware-specific-implementation, which actually makes the most sense if the behavior differs from the nk3an

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:fido bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants