hotp-verification hash upstream points to later available commit while nitrokey fork points to 1.4?

[tlaurion]

Also, hotp-verification hash upstream points to later available commit while nitrokey fork points to 1.4?

Upstream:
https://github.com/linuxboot/heads/blob/ee1978ffc0afa4db1b0a46517aff946912cdca14/modules/hotp-verification#L5-L10

Nitrokey:

heads/modules/hotp-verification

Lines 5 to 10 in da154df

	# v1.4 (change me)
	hotp-verification_version := 34b47aa75c07522d416c915911eed820556f1da8
	hotp-verification_dir := hotp-verification-$(hotp-verification_version)
	hotp-verification_tar := nitrokey-hotp-verification-$(hotp-verification_version).tar.gz
	hotp-verification_url := https://github.com/Nitrokey/nitrokey-hotp-verification/archive/$(hotp-verification_version).tar.gz
	hotp-verification_hash := cb5a8d8cf3da57a1e3fe82251220a0dfafbbf8e25a816c322fb5b00d485d7a9b

Was the latest hotp-verification code not aimed to be used upstream @daringer ?

Originally posted by @tlaurion in #48 (comment)

[daringer]

the heads upstream version is v1.5 - this is all correct, and functionally identical - just not perfectly clean executed....

this (34b47aa75c07522d416c915911eed820556f1da8) is functionally identical, just without the updated version string, which is done here: e9d8082af43a2cdc20c08f78cb2d59f30d4f4076 and then released as v1.5 using the commit you see upstream: 70c04f51387eee8f777e943ba83b6405764a3cd2

[tlaurion]

@daringer downstram and upstream should be limited to changes waiting to be part of an upstream commit outside of branding AFAIK?

[daringer]

yep, you are totally right, we are working on the next release already - there it will be fixed