Pin hash space opt #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sosthene-nitrokey
force-pushed
the
pin-hash-space-opt
branch
from
d813aac
to
296aeda
Compare
sosthene-nitrokey
force-pushed
the
pin-hash-space-opt
branch
from
155b55f
to
d2dd53c
Compare
sosthene-nitrokey
force-pushed
the
pin-hash-space-opt
branch
from
d2dd53c
to
09bdc7d
Compare
sosthene-nitrokey
force-pushed
the
pin-hash-space-opt
branch
from
09bdc7d
to
b18cae9
Compare
Cargo.toml
Outdated
| @@ -72,6 +72,7 @@ x509-parser = "0.16.0" | |||
| features = ["dispatch"] | |||
|
|
|||
| [patch.crates-io] | |||
| cbor-smol = { git = "https://github.com/sosthene-nitrokey/cbor-smol.git", rev = "94ee8c28edf9248b402aa4335c1dee157995197b"} | |||
There was a problem hiding this comment.
I fear that this is a change that could easily be missed when updating dependencies, breaking existing state. What do you think about introducing a dummy feature in the fork like bytes-from-array so that we get an error if we don’t have the correctly patched cbor-smol version?
There was a problem hiding this comment.
Actually this change is already in nitrokey-3-firmware
robin-nitrokey
approved these changes
Jul 26, 2024
daringer
approved these changes
Jul 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduce the storage space used by the hash of the PIN by using serde-byte-array. Fix #49
Needs trussed-dev/cbor-smol#7 to properly deserialize credentials that were serialize prior to this PR such as the one in the test.