From 33f19dad0aabf439bcbbd9a04642496c532682f7 Mon Sep 17 00:00:00 2001 From: Nish <257724087+nish3451@users.noreply.github.com> Date: Tue, 11 Aug 2026 20:48:36 +0530 Subject: [PATCH] fix(public): review-dispose the managed-service section absence as snoozed by design Grok live-review finding ([unreviewed-by-grok]): the live homepage is missing the entire
block while the merged homepage on main carries it. Verified 2026-08-11: intended, not a regression - the managed-service buyer path (PRs #10/#11) is snoozed-by-Nish 2026-08-08, the release lane strips the section from every publishable bundle, and the live site (still the 2026-06-20 bundle 07acd07) predates PR #10. Encode the verdict in the guards so future reviews find it: - check-public-live-deploy.mjs: assert id="managed-service" and the exact section marker are absent from the live homepage (previously only covered indirectly via the 'Website Correction' phrase); document the disposition - prepare-public-deploy-bundle.mjs: forbid id="managed-service" in the bundle alongside the other snooze markers - docs/measurement/public-conversion-signal.md: record the review disposition with live evidence and the lift condition verify: npm test (623 checks, 0 failures); node scripts/check-public-live-deploy.mjs (new managed-service checks pass; the 6 stale-bundle failures predate this change); git diff --check --- docs/measurement/public-conversion-signal.md | 24 ++++++++++++++++++++ scripts/check-public-live-deploy.mjs | 15 ++++++++++++ scripts/prepare-public-deploy-bundle.mjs | 3 +++ 3 files changed, 42 insertions(+) diff --git a/docs/measurement/public-conversion-signal.md b/docs/measurement/public-conversion-signal.md index 6cadddcf..43321ac8 100644 --- a/docs/measurement/public-conversion-signal.md +++ b/docs/measurement/public-conversion-signal.md @@ -106,3 +106,27 @@ A tag being present or a link being opened proves nothing about completion. the contact wiring must be re-verified before any conversion conclusion is drawn. Under this rule, "no tagged clicks" and "no applications" are both observable, and either direction can be disproven by a single counterexample. + +## Review dispositions + +### 2026-08-11 — "homepage is missing the entire `
` block on the live site" + +Grok live-review finding, dispositioned by the tinystudio-in lane (2026-08-11): +the live homepage has no managed-service section while the merged homepage on +main carries one. Verdict: **intended, snooze honored — not a regression.** + +- The managed-service buyer path (PRs #10/#11) is snoozed-by-Nish (2026-08-08: + do not build, publish, or deploy it without his explicit yes). +- The release lane strips the entire section (and every buyer-path marker) + from the publishable bundle via `scripts/prepare-public-deploy-bundle.mjs` + (fail-closed in both directions), and the live deploy check asserts its + absence explicitly (`id="managed-service"` in + `scripts/check-public-live-deploy.mjs`, mirrored by + `scripts/test-public-deploy-bundle.mjs`). +- Live evidence 2026-08-11: `https://tinystudio.in/` contains no + `id="managed-service"`, no "Website Correction", no "website-correction", + and no `data-measure-source`. (The live site is still the 2026-06-20 bundle + 07acd07, which predates PR #10; the filter would strip the section even on a + fresh deploy.) +- The section returns only when Nish lifts the snooze; the fail-closed filter + is then updated deliberately, never silently. diff --git a/scripts/check-public-live-deploy.mjs b/scripts/check-public-live-deploy.mjs index 7cbfe538..b921c1dd 100644 --- a/scripts/check-public-live-deploy.mjs +++ b/scripts/check-public-live-deploy.mjs @@ -11,6 +11,16 @@ // 3. unknown URLs get a real 404, not the homepage (PR #34) // 4. homepage stays portfolio-only: brand-disambiguation copy (#29) live, // and no managed-service buyer-path content (#10/#11, snoozed). +// +// Review disposition (2026-08-11, Grok live-review finding "homepage is +// missing the entire
block on the live site +// while the merged homepage on main carries it"): intended, snooze honored. +// The section is deliberately absent from every publishable bundle - the +// snoozed-by-Nish (2026-08-08) managed-service buyer path from PRs #10/#11 is +// stripped by scripts/prepare-public-deploy-bundle.mjs and its absence is +// asserted here (explicitly via the id="managed-service" marker below) and by +// scripts/test-public-deploy-bundle.mjs. The section returns only when Nish +// lifts the snooze and the fail-closed filter is updated deliberately. import { join } from "node:path" import { fileURLToPath } from "node:url" import { dirname } from "node:path" @@ -22,6 +32,7 @@ const BUYER_PATH_MARKERS = [ "Website Correction", "website-correction", "data-measure-source", + 'id="managed-service"', ] let failures = 0 @@ -89,6 +100,10 @@ try { for (const marker of BUYER_PATH_MARKERS) { ok(!body.includes(marker), `homepage has no ${marker}`) } + ok( + !body.includes('
html.includes("website-correction") }, { label: "data-measure-source", test: (html) => html.includes("data-measure-source") }, { label: "managed service phrase", test: (html) => /managed\s+service/i.test(html) }, + // The entire managed-service homepage section (review finding 2026-08-11: + // the snoozed buyer path must never appear on the live homepage). + { label: "managed-service section id", test: (html) => html.includes('id="managed-service"') }, ] // Neutral merged fixes that must SURVIVE in the bundle (deploy proof).