Skip to content

Commit 894f68f

Browse files
Improve error messages for on-chain related greenfield operations (btcpayserver#6393)
* Improve error messages for on-chain related greenfield operations * Fix test
1 parent 796d8d4 commit 894f68f

File tree

2 files changed

+7
-4
lines changed

2 files changed

+7
-4
lines changed

BTCPayServer.Tests/ThirdPartyTests.cs

+1-1
Original file line numberDiff line numberDiff line change
@@ -345,7 +345,7 @@ public void CanSolveTheDogesRatesOnKraken()
345345
var fetcher = new RateFetcher(factory);
346346

347347
Assert.True(RateRules.TryParse("X_X=kraken(X_BTC) * kraken(BTC_X)", out var rule));
348-
foreach (var pair in new[] { "DOGE_USD", "DOGE_CAD", "DASH_CAD", "DASH_USD", "DASH_EUR" })
348+
foreach (var pair in new[] { "DOGE_USD", "DOGE_CAD" })
349349
{
350350
var result = fetcher.FetchRate(CurrencyPair.Parse(pair), rule, null, default).GetAwaiter().GetResult();
351351
Assert.NotNull(result.BidAsk);

BTCPayServer/Controllers/GreenField/GreenfieldStoreOnChainWalletsController.cs

+6-3
Original file line numberDiff line numberDiff line change
@@ -379,7 +379,7 @@ public async Task<IActionResult> CreateOnChainTransaction(string storeId, string
379379
if (network.ReadonlyWallet)
380380
{
381381
return this.CreateAPIError(503, "not-available",
382-
$"{network.CryptoCode} sending services are not currently available");
382+
$"This network only support read-only features");
383383
}
384384

385385
//This API is only meant for hot wallet usage for now. We can expand later when we allow PSBT manipulation.
@@ -573,8 +573,11 @@ payjoinOutputIndex is null
573573
WellknownMetadataKeys.MasterHDKey);
574574
if (!derivationScheme.IsHotWallet || signingKeyStr is null)
575575
{
576-
return this.CreateAPIError(503, "not-available",
577-
$"{network.CryptoCode} sending services are not currently available");
576+
var reason = !derivationScheme.IsHotWallet ?
577+
"You cannot send from a cold wallet" :
578+
"NBXplorer doesn't have the seed of the wallet";
579+
580+
return this.CreateAPIError(503, "not-available", reason);
578581
}
579582

580583
var signingKey = ExtKey.Parse(signingKeyStr, network.NBitcoinNetwork);

0 commit comments

Comments
 (0)