Configuration abstraction, centralization, grouping #404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Now it's way easier to see the config defaults, usages all in one place - Eliminated a bunch of repeated code - All config properties are easily accessible from the debugger - Config properties are defined in contracts/interfaces
|
The old custom way of parsing has been removed (aside from the default value interpretation, which must stay) completely and replaced by the new .NET Core ConfigurationBuilder. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The way config key strings and defaults were hamfisted (and sometimes repeated) all over the codebase didn't seem very elegant to me, so I've abstracted it into a couple of interfaces and moved all the parsing/implementation business into the MiNET.Console assembly.
I've also grouped it into logical blocks for better readability and usability.