Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Additional information of Album Art such as Image Type, Width & Height or Resolution. #366

Closed
kissthermite opened this issue Oct 18, 2023 · 5 comments · Fixed by #371
Closed

Additional information of Album Art such as Image Type, Width & Height or Resolution. #366

kissthermite opened this issue Oct 18, 2023 · 5 comments · Fixed by #371
Labels
feature New feature or request in-beta This issue is fixed in a beta version
Milestone
V2023.10.0

Comments

@kissthermite
Copy link

Image mock-up.
Picture 1: resolution as an overlay, like Front & Back on a corner of Album Art
Picture 2: a pop-up window showing the aforementioned additional information.

1

2
@nlogozzo nlogozzo added this to the V2023.10.0 milestone Oct 18, 2023
@nlogozzo nlogozzo added the feature New feature or request label Oct 18, 2023
@nlogozzo
Copy link
Member

Wow this looks really cool!

Maybe what we could do is where you put the resolution in Picture 1 instead we can put an info icon that the user can click to bring up the image properties dialog shown in Picture 2.

@nlogozzo nlogozzo mentioned this issue Oct 19, 2023
Merged
@nlogozzo
Copy link
Member

Here's WinUI:
image

GNOME coming next...

@nlogozzo
Copy link
Member

And here's GNOME:
image

Note we will change the row style to have the property style class once we support libadwaita 1.4

@nlogozzo nlogozzo added the in-beta This issue is fixed in a beta version label Oct 21, 2023
@nlogozzo
Copy link
Member

Please test the latest beta release with this feature: https://github.com/NickvisionApps/Tagger/releases/tag/2023.10.0-beta2 and let us know how it goes!

Will be available via flathub-beta within the hour

@kissthermite
Copy link
Author

Please test the latest beta release with this feature: https://github.com/NickvisionApps/Tagger/releases/tag/2023.10.0-beta2 and let us know how it goes!

Will be available via flathub-beta within the hour

image

image

Working as intended, and it does look good. I love it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature New feature or request in-beta This issue is fixed in a beta version
Projects
None yet
Milestone
V2023.10.0
Development

Successfully merging a pull request may close this issue.

Features and a Fix :) NickvisionApps/Tagger
2 participants
@nlogozzo @kissthermite