Skip to content
This repository has been archived by the owner on May 6, 2024. It is now read-only.

Create enum flags for Client methods #4

Closed
fsobolev opened this issue Jul 18, 2023 · 0 comments · Fixed by #10
Closed

Create enum flags for Client methods #4

fsobolev opened this issue Jul 18, 2023 · 0 comments · Fixed by #10
Labels
feature New feature or request
Milestone
V2023.7.1

Comments

@fsobolev
Copy link
Member

Client has methods like Seek that support flags. Currently flags are set as strings and should match flags from mpv manual. This can lead to unexpected crashes in case of typos or wrong flags.
Using enum flags will make these methods less error prone.
@fsobolev fsobolev added the feature New feature or request label Jul 18, 2023
@fsobolev fsobolev added this to the V2023.7.1 milestone Jul 18, 2023
@fsobolev fsobolev mentioned this issue Jul 29, 2023
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
feature New feature or request
Projects
None yet
Milestone
V2023.7.1
Development

Successfully merging a pull request may close this issue.

Flags for client methods, support for weak clients NickvisionApps/MPVSharp
1 participant
@fsobolev