From 35f8ba1ed416ab154d387c5e73dd439360acadab Mon Sep 17 00:00:00 2001 From: Mark McLoughlin Date: Fri, 24 Oct 2025 10:28:43 -0400 Subject: [PATCH] [NIXL][Metrics] Fix NIXL buckets It's post times that need the smaller bucket size, not transfer duration. Uniform 2kb to 16gb range: ``` >>> def human_size(bytes, units=[' bytes','KB','MB','GB','TB', 'PB', 'EB']): ... """ Returns a human readable string representation of bytes """ ... return str(bytes) + units[0] if bytes < 1024 else human_size(bytes>>10, units[1:]) ... >>> [human_size(2**(10+i)) for i in range(1, 25, 2)] ['2KB', '8KB', '32KB', '128KB', '512KB', '2MB', '8MB', '32MB', '128MB', '512MB', '2GB', '8GB'] ``` Signed-off-by: Mark McLoughlin --- .../kv_transfer/kv_connector/v1/nixl_connector.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/vllm/distributed/kv_transfer/kv_connector/v1/nixl_connector.py b/vllm/distributed/kv_transfer/kv_connector/v1/nixl_connector.py index 1774834be8c5..5799b9ca53ec 100644 --- a/vllm/distributed/kv_transfer/kv_connector/v1/nixl_connector.py +++ b/vllm/distributed/kv_transfer/kv_connector/v1/nixl_connector.py @@ -1787,7 +1787,7 @@ def __init__( nixl_histogram_xfer_time = self._histogram_cls( name="vllm:nixl_xfer_time_seconds", documentation="Histogram of transfer duration for NIXL KV Cache transfers.", - buckets=buckets, + buckets=buckets[1:], labelnames=labelnames, ) self.nixl_histogram_xfer_time = self.make_per_engine(nixl_histogram_xfer_time) @@ -1795,12 +1795,12 @@ def __init__( name="vllm:nixl_post_time_seconds", documentation="Histogram of transfer post time for NIXL KV" " Cache transfers.", - buckets=buckets[1:], + buckets=buckets, labelnames=labelnames, ) self.nixl_histogram_post_time = self.make_per_engine(nixl_histogram_post_time) # uniform 2kb to 16gb range - buckets = [2**10 + i for i in range(1, 24, 2)] + buckets = [2 ** (10 + i) for i in range(1, 25, 2)] nixl_histogram_bytes_transferred = self._histogram_cls( name="vllm:nixl_bytes_transferred", documentation="Histogram of bytes transferred per NIXL KV Cache transfers.",