Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reduce npm dependency exposure #459

Open
6 tasks
jgresham opened this issue Dec 14, 2023 · 0 comments
Open
6 tasks

reduce npm dependency exposure #459

jgresham opened this issue Dec 14, 2023 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@jgresham
Copy link
Member

jgresham commented Dec 14, 2023

Feature details

We have some low-effort npm dependencies that we can simply copy source code from their single index.js file and include it under our src/ and npm remove the dependency. Additionally, these deps are not changing or updating frequently.

  • Put the dependency in a single file
  • Verify that the license of the dependency allows for this
  • Include a link to the code in a comment at the top of a file and the dep's license

See https://github.com/NiceNode/nice-node/blob/main/src/main/util/escapePath.js as an example of this

Some example deps to do this for:

  • await-sleep
  • i18next-cli-language-detector
  • gha apple codesign certs
@jgresham jgresham added enhancement New feature or request good first issue Good for newcomers labels Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant