Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Game: Bannerlord Support #130

Closed
wants to merge 84 commits into from
Closed

Game: Bannerlord Support #130

wants to merge 84 commits into from

Conversation

Aragas
Copy link
Contributor

@Aragas Aragas commented Feb 20, 2023

Implemented:

  • Steam
  • GOG
  • Epic
  • Windows Game Store
  • Game Version Resolution
  • Save Location
  • Testing Mods
  • Installing Mods
  • Diagnosing Mods
  • Sorting Mods

@Aragas Aragas changed the title Bannerlord Support Game: Bannerlord Support Feb 20, 2023
Using RandomAccess for performance gains
Added Tools for launching
Added NoWarn for CS1591
@Aragas
Copy link
Contributor Author

Aragas commented Feb 20, 2023

Feedback:

  • There's a need for a conditional ITool. For example, the tool should only be available if a specific mod is installed.
  • Metadata for Mod. You can add some metadata for a concrete file within a mod, but not for the mod.
    This can be worked around by using a concrete mod file to store the data.

@codecov-commenter
Copy link

codecov-commenter commented Mar 3, 2023

Codecov Report

❗ No coverage uploaded for pull request base (main@363b68a). Click here to learn what that means.
The diff coverage is 44.52%.

❗ Current head 81ba458 differs from pull request most recent head 398aded. Consider uploading reports for the commit 398aded to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #130   +/-   ##
=======================================
  Coverage        ?   59.79%           
=======================================
  Files           ?      475           
  Lines           ?    13721           
  Branches        ?     1139           
=======================================
  Hits            ?     8204           
  Misses          ?     5178           
  Partials        ?      339           
Flag Coverage Δ
Linux 59.23% <44.52%> (?)
Windows 59.47% <44.52%> (?)
clean_environment_tests 59.71% <44.52%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ndBlade2Bannerlord/Extensions/LoadoutExtensions.cs 0.00% <0.00%> (ø)
....MountAndBlade2Bannerlord/Utils/GamePathProvier.cs 0.00% <0.00%> (ø)
...s.MountAndBlade2Bannerlord/Utils/SortRulesUtils.cs 0.00% <0.00%> (ø)
....Games.MountAndBlade2Bannerlord/RunLauncherTool.cs 14.70% <14.70%> (ø)
...ames.MountAndBlade2Bannerlord/RunStandaloneTool.cs 20.00% <20.00%> (ø)
...de2Bannerlord/Services/LauncherManagerNexusMods.cs 20.75% <20.75%> (ø)
....Games.MountAndBlade2Bannerlord/Utils/Converter.cs 27.27% <27.27%> (ø)
...nerlord/Services/LauncherManagerNexusMods.Utils.cs 44.44% <44.44%> (ø)
...lord/Analyzers/MountAndBlade2BannerlordAnalyzer.cs 56.25% <56.25%> (ø)
...Installers/MountAndBlade2BannerlordModInstaller.cs 62.65% <62.65%> (ø)
... and 8 more

@Aragas
Copy link
Contributor Author

Aragas commented Oct 9, 2023

I agree that we need some game level optional layer that could parse the present folders as archives and do a "virtual" installation

@Greg-Nexus Greg-Nexus linked an issue Oct 12, 2023 that may be closed by this pull request
12 tasks
@erri120 erri120 removed their request for review October 18, 2023 14:05
@erri120 erri120 removed their assignment Oct 18, 2023
@github-actions
Copy link
Contributor

This PR conflicts with main. You need to rebase the PR before it can be merged.

@halgari
Copy link
Collaborator

halgari commented Nov 8, 2023

I've let this sit out way too long, I apoligize for that. Does this PR mostly work aside from mod sorting? Should we merge it then add sort support, or what do you think the best course of action is here @Aragas?

@Aragas
Copy link
Contributor Author

Aragas commented Nov 9, 2023

I've let this sit out way too long, I apoligize for that. Does this PR mostly work aside from mod sorting? Should we merge it then add sort support, or what do you think the best course of action is here @Aragas?

Thant's okay! The Bannerlord support also brings up the BUTR Bannerlord management library that was designed for Native Launcher/Vortex in terms of the API, so I was waiting for the NexusMods App API to stabilize, so you won't have the burden of adapting those API's.

In it's current state, it should support every feature NexusMods.App has, but I wasn't able to test sorting on the UI.
And we don't have yet the ability to find any existing mods within the game's installation, but it can be resolved when the feature arrives. Note tho, because of that you won't be able to correctly launch the game unless we hardcode the pre-existing official mods.

I'm fine with this PR's being in a draft for a while longer to reduce the mainenance burden, up to you to decide @halgari. I expect to be able to support with any issues within 1-2 days max

Copy link
Contributor

github-actions bot commented Nov 9, 2023

This PR doesn't conflict with main anymore. It can be merged after all status checks have passed and it has been reviewed.

@Aragas
Copy link
Contributor Author

Aragas commented Nov 20, 2023

Sorting is implemented and tested

Copy link
Contributor

This PR conflicts with main. You need to rebase the PR before it can be merged.

@halgari halgari marked this pull request as ready for review November 30, 2023 17:03
@halgari halgari mentioned this pull request Nov 30, 2023
@halgari halgari closed this in #799 Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BLOCKED This ticket cannot be completed until another ticket is completed
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Game Support - Mount & Blade 2: Bannerlord
6 participants