-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Game: Bannerlord Support #130
Conversation
Using RandomAccess for performance gains Added Tools for launching Added NoWarn for CS1591
Feedback:
|
# Conflicts: # NexusMods.App.sln # src/NexusMods.App/Program.cs
Switched to static gamedomain
# Conflicts: # src/NexusMods.App/Services.cs
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #130 +/- ##
=======================================
Coverage ? 59.79%
=======================================
Files ? 475
Lines ? 13721
Branches ? 1139
=======================================
Hits ? 8204
Misses ? 5178
Partials ? 339
Flags with carried forward coverage won't be shown. Click here to find out more.
|
# Conflicts: # src/NexusMods.App/Program.cs
Process start additional checks
# Conflicts: # src/NexusMods.App/NexusMods.App.csproj
# Conflicts: # src/NexusMods.DataModel/Games/GameDomain.cs
# Conflicts: # NexusMods.App.sln
# Conflicts: # NexusMods.App.sln
I agree that we need some game level optional layer that could parse the present folders as archives and do a "virtual" installation |
This PR conflicts with |
I've let this sit out way too long, I apoligize for that. Does this PR mostly work aside from mod sorting? Should we merge it then add sort support, or what do you think the best course of action is here @Aragas? |
Thant's okay! The Bannerlord support also brings up the BUTR Bannerlord management library that was designed for Native Launcher/Vortex in terms of the API, so I was waiting for the NexusMods App API to stabilize, so you won't have the burden of adapting those API's. In it's current state, it should support every feature NexusMods.App has, but I wasn't able to test sorting on the UI. I'm fine with this PR's being in a draft for a while longer to reduce the mainenance burden, up to you to decide @halgari. I expect to be able to support with any issues within 1-2 days max |
This PR doesn't conflict with |
Added custom sorting
Exposed ModSortRules Added SortRules propagation
Added ViewModelCreator delegate for tests
Sorting is implemented and tested |
This PR conflicts with |
Implemented: