Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why are we checking for 20 and 19 specifically? #16

Open
aadarshsingh191198 opened this issue Dec 8, 2022 · 2 comments
Open

Why are we checking for 20 and 19 specifically? #16

aadarshsingh191198 opened this issue Dec 8, 2022 · 2 comments

Comments

@aadarshsingh191198
Copy link
Contributor

@Javihaus
Copy link
Contributor

To detect if this data can be a datetime

@aadarshsingh191198
Copy link
Contributor Author

I get that ... But why just 20 and 19? There should be a better way. Maybe parse the value using a date parser and if doesn't throw an exception, we can say it's a date. But that would be slow. We could check in an array of possible values: 1 - 31 something.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants