Skip to content
This repository has been archived by the owner on Oct 12, 2022. It is now read-only.

NexmoServiceProvider.php #60

Closed

Conversation

nat-mystudiosessions
Copy link

Thanks so much for this great tool! This error stumped me for a good while. The way I was reading the error I thought it wasn't getting either the api_secret or the signature_secret. I knew I was providing the api_secret so I wasn't understanding what the problem could be. After a bit of head scratching and digging I found this line in the code and realized that I was providing both the api_secret and the signature_secret values in my .env file, I didn't know that would cause a problem. When I removed the signature_secret value the code worked perfectly. In conclusion, this is just an updated error message to help the next person understand what they're doing wrong. Thanks again.

Description

Motivation and Context

How Has This Been Tested?

Example Output or Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Thanks so much for this great tool! This error stumped me for a good while. The way I was reading the error I thought it wasn't getting either the api_secret or the signature_secret. I knew I was providing the api_secret so I wasn't understanding what the problem could be. After a bit of head scratching and digging I found this line in the code and realized that I was providing both the api_secret and the signature_secret values in my .env file, I didn't know that would cause a problem. When I removed the signature_secret value the code worked perfectly. In conclusion, this is just an updated error message to help the next person understand what they're doing wrong. Thanks again.
Base automatically changed from main to 2.x February 25, 2021 15:35
@driesvints
Copy link
Contributor

@nat-mystudiosessions added this to my PR at laravel/vonage-notification-channel#53

@SecondeJK
Copy link
Contributor

This package is officially abandoned in favour of https://github.com/Vonage/vonage-laravel. Please use that, and open tickets in that repo if required, thanks.

@SecondeJK SecondeJK closed this Oct 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants