[fix] 如果分隔符是 \u0001，则必须使用Ordinal，否则无法分割直接返回0。在RocketMQ中有这种情况。NewLifeX/NewLife.RocketMQ#93

Author: nnhy

NewLife.Core/Extension/StringHelper.cs

@@ -126,13 +126,14 @@ public static Int32[] SplitAsInt(this String? value, params String[] separators)
         if (nameValueSeparator.IsNullOrEmpty()) nameValueSeparator = "=";
         //if (separator == null || separator.Length <= 0) separator = new String[] { ",", ";" };
 
-        var ss = value.Split(new[] { separator }, StringSplitOptions.RemoveEmptyEntries);
+        var ss = value.Split([separator], StringSplitOptions.RemoveEmptyEntries);
         if (ss == null || ss.Length <= 0) return dic;
 
         var k = 0;
         foreach (var item in ss)
         {
-            var p = item.IndexOf(nameValueSeparator);
+            // 如果分隔符是 \u0001，则必须使用Ordinal，否则无法分割直接返回0。在RocketMQ中有这种情况
+            var p = item.IndexOf(nameValueSeparator, StringComparison.Ordinal);
             if (p <= 0)
             {
                 dic[$"[{k}]"] = item;
@@ -544,7 +545,7 @@ public static String CutStart(this String str, params String[] starts)
 
         for (var i = 0; i < starts.Length; i++)
         {
-            var p = str.IndexOf(starts[i]);
+            var p = str.IndexOf(starts[i], StringComparison.Ordinal);
             if (p >= 0)
             {
                 str = str[(p + starts[i].Length)..];
@@ -565,7 +566,7 @@ public static String CutEnd(this String str, params String[] ends)
 
         for (var i = 0; i < ends.Length; i++)
         {
-            var p = str.LastIndexOf(ends[i]);
+            var p = str.LastIndexOf(ends[i], StringComparison.Ordinal);
             if (p >= 0)
             {
                 str = str[..p];

XUnitTest.Core/Extension/StringHelperTests.cs

@@ -101,4 +101,17 @@ public void SplitAsDictionary()
         Assert.False(rules.ContainsKey("ip"));
         Assert.False(rules.ContainsKey("iP"));
     }
+
+    [Fact]
+    public void SplitAsDictionary2()
+    {
+        var str = "TAGS\u0001Tag1\u0002KEYS\u0001Key1\u0002DELAY\u00012\u0002WAIT\u0001False\u0002";
+        var dic = str.SplitAsDictionary("\u0001", "\u0002");
+
+        Assert.Equal(4, dic.Count);
+        Assert.Equal("Tag1", dic["TAGS"]);
+        Assert.Equal("Key1", dic["Keys"]);
+        Assert.Equal("2", dic["DELAY"]);
+        Assert.Equal("False", dic["WAIT"]);
+    }
 }