Skip to content

Commit 62899c0

Browse files
author
bors-servo
authored
Auto merge of servo#25334 - asajeffrey:gstplugins-misc-tidying-up, r=jdm
Gstreamer plugin running in wayland with surfman 0.2 <!-- Please describe your changes on the following line: --> Tidying up the gstreamer plugin. The plugin now: * uses surfman 0.2 * runs in wayland (but can't render WebGL content yet) * gets its GL configuration from gstreamer * uses GLsync if needed --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix servo#24843 - [X] These changes do not require tests because <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
2 parents 352e227 + b5943f5 commit 62899c0

File tree

7 files changed

+318
-135
lines changed

7 files changed

+318
-135
lines changed

Cargo.lock

+48-8
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

etc/taskcluster/decision_task.py

+3-3
Original file line numberDiff line numberDiff line change
@@ -491,9 +491,9 @@ def windows_unit(cached=True):
491491
"mach smoketest --angle",
492492
"mach package --dev",
493493
"mach build --dev --libsimpleservo",
494-
# We're getting link errors on windows, due to the x11 feature being
495-
# enabled on gstreamer-gl. https://github.com/servo/media/pull/304/
496-
"mach build --dev --media-stack=dummy -p servo-gst-plugin",
494+
# The GStreamer plugin currently doesn't support Windows
495+
# https://github.com/servo/servo/issues/25353
496+
# "mach build --dev -p servo-gst-plugin",
497497

498498
)
499499
.with_artifacts("repo/target/debug/msi/Servo.exe",

ports/gstplugin/Cargo.toml

+3-4
Original file line numberDiff line numberDiff line change
@@ -22,18 +22,17 @@ glib = { version = "0.8", features = ["subclassing"] }
2222
gstreamer = { version = "0.14", features = ["subclassing"] }
2323
gstreamer-base = { version = "0.14", features = ["subclassing"] }
2424
gstreamer-gl = { version = "0.14" }
25-
gstreamer-gl-sys = { version = "0.8" }
25+
gstreamer-gl-sys = { version = "0.8", features = ["wayland"] }
2626
gstreamer-sys = { version = "0.8" }
2727
gstreamer-video = { version = "0.14", features = ["subclassing"] }
2828
log = "0.4"
2929
lazy_static = "1.4"
3030
libservo = {path = "../../components/servo"}
3131
servo-media = {git = "https://github.com/servo/media"}
3232
sparkle = "0.1"
33-
# NOTE: the sm-angle-default feature only enables angle on windows, not other platforms!
34-
surfman = { version = "0.1", features = ["sm-angle-default", "sm-osmesa"] }
33+
surfman = { git = "https://github.com/pcwalton/surfman", branch = "multi" }
3534
surfman-chains-api = "0.2"
36-
surfman-chains = "0.2.1"
35+
surfman-chains = { git = "https://github.com/asajeffrey/surfman-chains", branch = "multi" }
3736

3837
[build-dependencies]
3938
gst-plugin-version-helper = "0.1"

ports/gstplugin/README.md

+5-2
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,10 @@
11
# A GStreamer plugin which runs servo
22

3+
## Supported platforms
4+
5+
* MacOS + CGL
6+
* Linux + Wayland (currently no WebGL content)
7+
38
## Build
49

510
```
@@ -68,8 +73,6 @@ LD_LIBRARY_PATH=$PWD/support/linux/gstreamer/gst/lib \
6873

6974
## Troubleshooting running the plugin
7075

71-
*Currently x11 support is broken!*
72-
7376
First try:
7477
```
7578
GST_PLUGIN_PATH=target/gstplugins \

ports/gstplugin/logging.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ use lazy_static::lazy_static;
99

1010
lazy_static! {
1111
pub static ref CATEGORY: DebugCategory =
12-
DebugCategory::new("servosrc", DebugColorFlags::empty(), Some("Servo"));
12+
DebugCategory::new("servowebsrc", DebugColorFlags::empty(), Some("Servo"));
1313
}
1414

1515
pub static LOGGER: ServoSrcLogger = ServoSrcLogger;

0 commit comments

Comments
 (0)