Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Numpy 2.0 #1956

Merged
merged 12 commits into from
Sep 4, 2024
Merged

Numpy 2.0 #1956

merged 12 commits into from
Sep 4, 2024

Conversation

mavaylon1
Copy link
Collaborator

@mavaylon1 mavaylon1 commented Sep 4, 2024

Motivation

What was the reasoning behind this change? Please explain the changes briefly.

Support numpy 2.0

How to test the behavior?

Show how to reproduce the new behavior (can be a bug fix or a new feature)

Checklist

  • Did you update CHANGELOG.md with your changes?
  • Have you checked our Contributing document?
  • Have you ensured the PR clearly describes the problem and the solution?
  • Is your contribution compliant with our coding style? This can be checked running ruff check . && codespell from the source directory.
  • Have you checked to ensure that there aren't other open Pull Requests for the same change?
  • Have you included the relevant issue number using "Fix #XXX" notation where XXX is the issue number? By including "Fix #XXX" you allow GitHub to close issue #XXX when the PR is merged.

@mavaylon1 mavaylon1 marked this pull request as draft September 4, 2024 17:51
Copy link

codecov bot commented Sep 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.20%. Comparing base (609eaac) to head (4ee549c).
Report is 1 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #1956   +/-   ##
=======================================
  Coverage   92.20%   92.20%           
=======================================
  Files          27       27           
  Lines        2656     2656           
  Branches      693      693           
=======================================
  Hits         2449     2449           
  Misses        134      134           
  Partials       73       73           
Flag Coverage Δ
integration 73.19% <ø> (+0.03%) ⬆️
unit 83.77% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mavaylon1 mavaylon1 marked this pull request as ready for review September 4, 2024 18:25
@mavaylon1 mavaylon1 enabled auto-merge (squash) September 4, 2024 18:26
Copy link
Contributor

@stephprince stephprince left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor fix but otherwise looks good.

Thank you for fixing the links!

docs/source/export.rst Outdated Show resolved Hide resolved
@mavaylon1 mavaylon1 merged commit aaa4d65 into dev Sep 4, 2024
23 of 24 checks passed
@mavaylon1 mavaylon1 deleted the numpy2 branch September 4, 2024 20:55
@rly rly mentioned this pull request Sep 8, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants