-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add comments to io/file.py #1925
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #1925 +/- ##
==========================================
- Coverage 91.88% 83.98% -7.91%
==========================================
Files 27 27
Lines 2651 2648 -3
Branches 692 691 -1
==========================================
- Hits 2436 2224 -212
- Misses 142 329 +187
- Partials 73 95 +22
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
very helpful, thanks!
datestr = builder.get('file_create_date').data | ||
dates = list(map(dateutil_parse, datestr)) | ||
return dates | ||
|
||
@ObjectMapper.constructor_arg('file_name') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just wanted to clarify why this constructor was removed? Otherwise, looks good to me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whoops I forgot to mention that. This maps a constructor argument that doesn't exist. It must have been a legacy thing.
Motivation
io/file.py
and object mapping is a confusing concept. This came up in discussion today. This PR adds comments to the methods inio/file.py
.Checklist
flake8
from the source directory.