Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add comments to io/file.py #1925

Merged
merged 3 commits into from
Jun 28, 2024
Merged

Add comments to io/file.py #1925

merged 3 commits into from
Jun 28, 2024

Conversation

rly
Copy link
Contributor

@rly rly commented Jun 27, 2024

Motivation

io/file.py and object mapping is a confusing concept. This came up in discussion today. This PR adds comments to the methods in io/file.py.

Checklist

  • Did you update CHANGELOG.md with your changes?
  • Have you checked our Contributing document?
  • Have you ensured the PR clearly describes the problem and the solution?
  • Is your contribution compliant with our coding style? This can be checked running flake8 from the source directory.
  • Have you checked to ensure that there aren't other open Pull Requests for the same change?
  • Have you included the relevant issue number using "Fix #XXX" notation where XXX is the issue number? By including "Fix #XXX" you allow GitHub to close issue #XXX when the PR is merged.

@rly rly requested a review from stephprince June 27, 2024 21:57
Copy link

codecov bot commented Jun 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.98%. Comparing base (3c5fa48) to head (a82fae8).
Report is 19 commits behind head on dev.

❗ There is a different number of reports uploaded between BASE (3c5fa48) and HEAD (a82fae8). Click for more details.

HEAD has 4 uploads less than BASE
Flag BASE (3c5fa48) HEAD (a82fae8)
integration 4 0
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1925      +/-   ##
==========================================
- Coverage   91.88%   83.98%   -7.91%     
==========================================
  Files          27       27              
  Lines        2651     2648       -3     
  Branches      692      691       -1     
==========================================
- Hits         2436     2224     -212     
- Misses        142      329     +187     
- Partials       73       95      +22     
Flag Coverage Δ
integration ?
unit 83.98% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@stephprince stephprince left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very helpful, thanks!

datestr = builder.get('file_create_date').data
dates = list(map(dateutil_parse, datestr))
return dates

@ObjectMapper.constructor_arg('file_name')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just wanted to clarify why this constructor was removed? Otherwise, looks good to me!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops I forgot to mention that. This maps a constructor argument that doesn't exist. It must have been a legacy thing.

@rly rly enabled auto-merge (squash) June 28, 2024 02:03
@rly rly merged commit c99c0c5 into dev Jun 28, 2024
19 of 24 checks passed
@rly rly deleted the io_comments2 branch June 28, 2024 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants